Conversation

hseg

Features:

  • Convert plugin from Importer to Downloader
  • Removed attempt to download from crossref first
  • Removed dependency on scihub, instead plugin scrapes the actual webpage
    using bs4
  • BibTeX metadata is pulled from https://doi.org
  • Update to use pyproject.toml instead of setup.py
  • Replace README.rst by README.md

Diff off original:

  • Restore static versions (at least until repo starts tagging versions)
    • Add (commented-out) [tool.setuptools_scm] section to silence
      warnings once repo uses dynamic versioning
  • Restore unnecessary edits
    • Restore liability warning
    • Restore version bounds (guessed for bs4)
    • Restore classifiers, keywords, authors
    • Relax python version bounds
    • Explicitly use standard GPL3 text
  • Make pylint-clean for python >=3.6
    • Convert | None to uses of Optional[] to silence warnings on
      Pythons older than 3.10
    • Use more specific exceptions
    • Clean up early-exit logic, drop useless exception catches
    • Standardize names
  • Misc improvements
    • Fix download_bibtex() type
    • Add sci-hub mirrors

Closes: #37

* Restore static versions (at least until repo starts tagging versions)
  * Add (commented-out) [tool.setuptools_scm] section to silence
    warnings once repo uses dynamic versioning
* Restore unnecessary edits
  * Restore liability warning
  * Restore version bounds (guessed for bs4)
  * Restore classifiers, keywords, authors
  * Relax python version bounds
  * Explicitly use standard GPL3 text
* Make pylint-clean for python >=3.6
  * Convert `| None` to uses of `Optional[]` to silence warnings on
    Pythons older than 3.10
  * Use more specific exceptions
  * Clean up early-exit logic, drop useless exception catches
  * Standardize names
* Misc improvements
  * Fix `download_bibtex()` type
  * Add sci-hub mirrors
@hseg

Would've squashed the original commits to prevent some of the noise, but wanted to preserve attribution.

@hseghseg mentioned this pull request Dec 6, 2023
@hseg

Any updates on this? It should be a clean merge.

@hseg

@alejandrogallo Mind merging this? At the moment, the AUR package is building off my branch, which is not ideal.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

@hseg