Conversation

alexturcea

closes #6251

@alexturcea

If anyone has time to double check these changes it would be very helpful. Essentially, there are a few issues that this fix should address:

  1. when using scattergl with a multiframe plot (i.e. an animation), the scatterplot is only visible on one frame
  2. even if the above is fixed (see my first suggested fix), when the number of plots is changing across frames, the plot is not updating correctly.
  3. similar to 2. , when the number of annotations is changing across frames, the plot is not updating correctly

@alexcjohnson @archmoj @jonmmease

@@ -348,7 +347,7 @@ var exports = module.exports = function plot(gd, subplot, cdata) {
(yaxis._rl || yaxis.range)[1]
]
};
var vpRange = Lib.repeat(vpRange0, scene.count);
var vpRange = Lib.repeat(vpRange0, cdata.length);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required?

@alexturcea

Code to reproduce: https://jsfiddle.net/gcptmL6v/

With the proposed fix: https://jsfiddle.net/q2wt06d3/

@alexcjohnson

@alexturcea great! Nicely done, and your fiddles are very convincing. I'll let @archmoj give the code a review, but we'll need to adapt your fiddle to a test we can run on CI - maybe in animate_test.js? And hopefully we can pare it down to something small and readable 😉

A bunch of failures in the CI runs, but they don't look like the kind of thing that would have resulted from your changes.

@alexturcea

Hi @alexcjohnson @archmoj , I synched this with the main branch, still hoping to have it merged 😄

@alexcjohnson

Thanks @alexturcea - as I mentioned before, we'll need to adapt your fiddle into a test, would you be able to try that? We'll also need a draftlog item.

@archmojarchmoj added bugsomething brokencommunitycommunity contributionstatus: reviewable labels May 27, 2024
@archmoj

Please fetch upstream/master and merge in the branch.
Then please update your https://jsfiddle.net/q2wt06d3/ using a build from publish-dist/artifacts.
Thank you!

@gvwilsongvwilson changed the title Fix for https://.com/plotly/plotly.js/issues/6251 fix for Scattergl animation bug May 29, 2024
@@ -53,7 +53,6 @@ var exports = module.exports = function plot(gd, subplot, cdata) {
return;
}

var count = scene.count;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to just var count = cdata.length in that case - and remove all the other changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! @eiriklv Could you please fetch upstream/master on your fork and test it by opening a PR?

@archmoj

@alexturcea Are you interested in completing this PR?
Could you try @eiriklv suggestion?
#6452 (comment)

@archmojarchmoj modified the milestones: v2.34.0, v2.35.0 Jul 13, 2024
@gvwilsongvwilson added fixfixes something brokenP2considered for next cycleand removed status: has TODOs bugsomething brokenlabels Aug 8, 2024
@archmojarchmoj modified the milestones: v2.35.0, v2.36.0 Aug 22, 2024
@archmojarchmoj modified the milestones: v2.36.0, v3.1.0 Oct 22, 2024
@gvwilsongvwilson assigned gvwilson and unassigned archmoj Nov 20, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
communitycommunity contributionfixfixes something brokenP2considered for next cycle
None yet

Successfully merging this pull request may close these issues.

bug when animating Scattergl