Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🙏 Many thanks @emilykl
Switching from
master
tomain
broke these.I suspect a similar problem would occur again.
I feel to avoid file changes (that occur on
master
/main
branch of these repositories) it would be best to use permanent links for all these font files e.g.https://.com/expo/google-fonts/tree/cc65b43125023a2ad696eeec6ec10763c35ff588/font-packages/gravitas-one/400Regular
instead ofhttps://.com/expo/google-fonts/blob/main/font-packages/gravitas-one/400Regular/
.Thank you!