Conversation

gvwilson

@gvwilsongvwilson requested a review from emilykl May 22, 2025 18:59
@gvwilsongvwilson self-assigned this May 22, 2025
@gvwilsongvwilson added P1needed for current cyclefixfixes something brokenregressionthis used to worklabels May 22, 2025
@gvwilsongvwilson mentioned this pull request May 22, 2025
Closed
emilykl
emilykl approved these changes May 23, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Confirming that this seems to fix syntax highlighting in VSCode on my machine.

@gvwilson
feat: restore type checking portion of code generation
86514e1
-   Restore code removed in #4978.
-   (Partially) closes #5186.
-   Remove unneeded imports of `sys`.
@gvwilson
feat: restore type checking support in generated code
44907a3
-   Restore code removed in #4978.
-   Add `test_path.png` to `.gitignore`.
-   Closes #5186.
@gvwilsongvwilson force-pushed the fix-5186-type-checking-renegerate-code branch from 848f68e to 44907a3 Compare May 25, 2025 12:48
@gvwilson

updated to remove sys imports and check again version 3.7

@kszlim

I'm curious if there will be a (relatively quick) version released once this makes it in?

@gvwilson

@kszlim coming soon

@gvwilsongvwilson mentioned this pull request May 27, 2025
Open
@gvwilsongvwilson merged commit 7bc7ce5 into main May 27, 2025
10 checks passed
@gvwilsongvwilson deleted the fix-5186-type-checking-renegerate-code branch June 4, 2025 12:43
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@emilykl emilykl emilykl approved these changes

@gvwilson gvwilson

fixfixes something brokenP1needed for current cycleregressionthis used to work
None yet
No milestone

Successfully merging this pull request may close these issues.