Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eriknw commented May 3, 2023
Comment on lines +248 to +249
| B << select.valuene(B, False) | ||
| Indices << indexunary.rowindex(B) |
There was a problem hiding this comment.
These two lines could be replaced with
Indices(B.V, replace) << indexunary.rowindex(B)but I think it's clearer in two lines (using masking with replace is kind of ugly). I don't know if there is a performance difference.
YOLO :) Happy to receive feedback even after merging |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are several algorithms that return one or more paths, so this PR can help blaze the way to determine how we do this.
I do something different for parent Bellman-Ford by not using UDTs/UDFs. I'm not sure if it's the best way. This also hasn't been benchmarked. YOLO.