+48 −2

Conversation

Fidget-Spinner

@Fidget-SpinnerFidget-Spinner changed the title gh-135608: Add a null check for attribute promotion to fix a crash gh-135608: Add a null check for attribute promotion to fix a JIT crash Jun 17, 2025
@bedevere-appbedevere-app bot mentioned this pull request Jun 17, 2025
Open
@Fidget-Spinner @devdanzin
Update test_opt.py
092ecc5
Co-Authored-By: devdanzin <[email protected]>
@tomasr8

I'll take a look today or tomorrow :)

tomasr8
tomasr8 reviewed Jun 18, 2025
View reviewed changes
tomasr8
tomasr8 approved these changes Jun 19, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits/questions, otherwise LGTM! :)

@Fidget-Spinner

Thank you for the review. I have addressed the comments.

Sign up for free to join this conversation on . Already have an account? Sign in to comment

@tomasr8 tomasr8 tomasr8 approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon

No one assigned
awaiting merge
None yet
No milestone

Successfully merging this pull request may close these issues.