Conversation

samparks

Added a period to *.*format(tn= ...

Added a period to *.*format(tn= ...
@rasbt

Thanks! But I see that there are two periods now:

c.execute("UPDATE {tn} SET {cn}='sebastian_r' WHERE {idf}=123456".\
          .format(tn=table_name, idf=id_column, cn=new_column))

Could you please remove the upper one?

@samparks

Ah, sorry! I just realized that the places that I thought periods were needed, were just included above instead of on the new line! I'll let you close this unless you'd like for me to change them all for consistency.

@rasbt

No worries, and I think it's visually a bit misleading. I think we could leave it as is. It has a bit of those "when you see you old code and cringe" moments ;) I would put the period onto the new line if I wrote it today. Sth like

c.execute("UPDATE {tn} SET {cn}='sebastian_r' WHERE {idf}=123456"
          .format(tn=table_name, idf=id_column, cn=new_column))

(the backslash shouldn't be needed because of the parentheses.)

@samparks

👍 sounds good to me. Sorry for the confusion!

@rasbt

No worries, I appreciate it that you submitted a PR helping to fix it :)

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.