Conversation

jfrolich

No description provided.

jfrolich
jfrolich commented Sep 3, 2024
View reviewed changes
server/package.json
"vscode-languageserver": "^8.0.1",
"vscode-languageserver-protocol": "^3.17.1"
}
"name": "@rescript/language-server",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason this was tab formatted (and in the server it's spaces - I think spaces is more standard)

jfrolich
jfrolich commented Sep 3, 2024
View reviewed changes
server/src/utils.ts
@@ -70,7 +69,7 @@ export let findProjectRootOfFile = (
} else {
const isDir = path.extname(source) === "";
return findProjectRootOfFileInDir(
isDir ? path.join(source, "dummy.res") : source
isDir && !allowDir ? path.join(source, "dummy.res") : source
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused the fix to not work :|

@jfrolichjfrolich requested a review from zth September 3, 2024 12:00
@zth

You need to run npm install in both folders as well so the version is updated in the lockfile.

@jfrolich

You need to run npm install in both folders as well so the version is updated in the lockfile.

🙈 done!

@zthzth merged commit fd91104 into rescript-lang:master Sep 3, 2024
6 checks passed
@nojaf

Hello @jfrolich, could you describe your folder structure a bit where this originally went wrong. What kind of setup/folder structure did you have where the root could not be found?
I'm looking at findProjectRootOfFile and would like to learn why this seems more complicated than I would expect it to be.

Sign up for free to join this conversation on . Already have an account? Sign in to comment

@zth zth Awaiting requested review from zth

No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.