rescript-lang/syntax#168

TODO:

• update CHANGELOG

Quick check before even reading the code: this still parses the old style and converts to the new style, correct?

No, old style is a syntax error.

That's a breaking change.
Should accept it and convert it on format.

We can convert to the new format, but it changes the precedence.

// Before
assert 1 == 2
// Parsed as
(assert 1) == 2

// Now
assert(1 == 2)

Currently assert is an unary expression.

I think that OK. It's going to matter in very few cases.

Still: to be mentioned in release notes.

Are there tests that show that old style assert is still parsed? E.g. assert false without parens.

[cristianoc]

Not sure I understand why this code is required.
Seems oddly specific for a generic assert.

[aspeddro]

Removed in ef6501e. It is in fact no longer necessary.

Looking great!
Ready to merge?

👍🏾

It's the first time a hear about assert. Also, I haven't found it in the docs (besides the reserved keywords section). I wonder whether it should be removed from the compiler entirely and come to the userland.

It's the first time a hear about assert. Also, I haven't found it in the docs (besides the reserved keywords section). I wonder whether it should be removed from the compiler entirely and come to the userland.

The thing is avoiding breaking changes.
This is a small thing but by experience a couple of small things are enough to delay people upgrading compiler version.