Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Hi @cknitt, can I have a review? thanks :) |
cknitt reviewed Jan 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
src/Stack.res Outdated
| @@ -221,6 +217,10 @@ module Navigation = { | |||
| @send external pop: (navigation, ~count: int=?, unit) => unit = "pop" | |||
There was a problem hiding this comment.
With ReScript 11.1, we could get rid of the trailing unit everywhere.
src/Stack.res Outdated
| @@ -221,6 +217,10 @@ module Navigation = { | |||
| @send external pop: (navigation, ~count: int=?, unit) => unit = "pop" | |||
| @send external popTo: (navigation, string) => unit = "popTo" | |||
| @send | |||
| external popToWithParams: (navigation, string, 'params) => unit = "popTo" | |||
There was a problem hiding this comment.
With ReScript 11.1, we could have a single binding with an optional param (without trailing unit) instead.
Co-authored-by: Christoph Knittel <[email protected]>
cknitt approved these changes Jan 19, 2025
816a664 into main 2 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following : https://reactnavigation.org/docs/upgrading-from-6.x