Conversation
cores allocator_api cores allocator_apicores allocator_api a1fca2f to 81b2d33 Compare No need for this so far, but this provides downstream users more flexibility.
81b2d33 to 04e87f7 Compare uefi/src/allocator.rs Outdated
| #[cfg(feature = "unstable")] | ||
| unsafe impl core::alloc::Allocator for Allocator { | ||
| fn allocate(&self, layout: Layout) -> Result<NonNull<[u8]>, core::alloc::AllocError> { | ||
| let ptr = unsafe { <Allocator as GlobalAlloc>::alloc(self, layout) }; |
There was a problem hiding this comment.
Do we need to do something here to handle ZSTs? I'm not familiar with the details of the Allocator trait, but I noticed this in the documentation:
In contrast to
GlobalAlloc,Allocatorallows zero-sized allocations. If an underlying allocator does not support this (like jemalloc) or responds by returning a null pointer (such aslibc::malloc), this must be caught by the implementation.
There was a problem hiding this comment.
Yes, I'm just not sure how to handle it :D but I can figure it out, I guess
There was a problem hiding this comment.
Nice use case but you're right. I added it in a dedicated commit
Uh oh!
There was an error while loading. Please reload this page.
We used std::alloc::System as template. [0] https://doc.rust-lang.org/src/std/alloc.rs.html#137
| @@ -53,6 +51,44 @@ mod bootservices { | |||
| } | |||
| unsafe { boot::free_pool(ptr) }.unwrap(); | |||
| } | |||
| /// Tests getting the memory map. | |||
| pub fn test_memory_map() { | |||
There was a problem hiding this comment.
Moving this function seems unrelated to the rest of the PR -- could you drop this change or move it to a separate PR?
| unsafe impl core::alloc::Allocator for Allocator { | ||
| fn allocate(&self, layout: Layout) -> Result<NonNull<[u8]>, core::alloc::AllocError> { | ||
| // Stable alternative for Layout::dangling() | ||
| fn dangling_for_layout(layout: Layout) -> NonNull<u8> { |
There was a problem hiding this comment.
Since this is gated by unstable anyway, I think we might as well enable alloc_layout_extra and use Layout::dangling directly.
Closing for the same reason as discussed here: #1606 (comment) |
Implement the allocator API (of
core) for the UEFI allocator.Checklist