Conversation

Pratik772846

Resolves #1330

Description

What is the purpose of this pull request?

This pull request:

  • add tests to @stdlib/dstructs/compact-adjacency-matrix

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

added tests to @stdlib/utils/compact-adjacency-matrix

Fixes stdlib-js#1330
done some changes related to test messages

Fixes stdlib-js#1330
@Pratik772846

image
Hi @kgryte @Planeshifter ,These 2 tests to check property and method are failing for "fromEdge" method .But they are passing for all other methods.What can be the reason behind it?

@kgryte

@Pratik772846 The method is not a method, but a static method. You should be checking for a method on the constructor.

@kgrytekgryte changed the title feat: add tests to @stdlib/utils/compact-adjacency-matrix test: add tests to @stdlib/utils/compact-adjacency-matrix Apr 7, 2024
@kgrytekgryte added the TestsPull requests specifically adding tests.label Apr 7, 2024
@Pratik772846

@kgryte Sorry for the oversight. I have updated the tests. Please review it at your convenience.

@PlaneshifterPlaneshifter self-requested a review April 17, 2024 13:04
@PlaneshifterPlaneshifter added the Needs ReviewA pull request which needs code review.label Sep 8, 2024
@kgrytekgryte added Needs ChangesPull request which needs changes before being merged.and removed Needs ReviewA pull request which needs code review.labels Feb 23, 2025
@kgryte

This PR needs to be updated, as the compact-adjacency-matrix package has been moved to the dstructs namespace.

@kgrytekgryte changed the title test: add tests to @stdlib/utils/compact-adjacency-matrix test: add tests to @stdlib/dstructs/compact-adjacency-matrix Feb 23, 2025
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Needs ChangesPull request which needs changes before being merged.TestsPull requests specifically adding tests.
None yet

Successfully merging this pull request may close these issues.

[RFC]: add tests to @stdlib/dstructs/compact-adjacency-matrix