Description

What is the purpose of this pull request?

This pull request:

• add fixer function to eslint/rules/no-internal-require
• update the test fixtures

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[headlessNode]

Heads up. Currently, the auto-fixing for suggestion type is not supported.

This is an interesting one. I am not sure whether we should autofix this or not. If someone is reaching into a package for a particular file, we should probably just error. Auto-fixing could just lead to other issues.

@kgryte do we currently have anything calling the internals in the codebase? Also what other issues the auto-fixing could cause?

do we currently have anything calling the internals in the codebase?

@headlessNode Not that I am aware of.

Also what other issues the auto-fixing could cause?

If someone is reaching internally into a package and we autofix without their explicit opt-in, that could lead to unexpected behavior. E.g., if someone is expecting to load a data JSON file, but gets the main export of a package instead because we rewrote require expressions, they might not be aware that such a change has been made (e.g., tests aren't automatically run). That could lead to downstream bugs because we've silently changed behavior.

The reason why I recommend just raising a lint "error" is that we effectively force devs to confront the fact that they are reaching into a package when we generally don't want that. Devs could always explicitly disable the lint rule if they are insistent, but that would be an intentional choice.

@kgryte Makes sense. Should I close this PR then?