Conversation

manvith2003

Resolves #3662

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stats/base/dists/hypergeometric/mean along with relevant docs, tests, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@manvith2003
feat: add C implementation for stats/base/dists/hypergeometric/mean
3dc2063
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@stdlib-botstdlib-bot added StatisticsIssue or pull request related to statistical functionality.Needs ReviewA pull request which needs code review.labels Dec 24, 2024
@stdlib-bot

Coverage Report

PackageStatementsBranchesFunctionsLines
stats/base/dists/hypergeometric/mean$\color{green}202/202$
$\color{green}+100.00\%$		$\color{green}17/17$
$\color{green}+100.00\%$		$\color{green}2/2$
$\color{green}+100.00\%$		$\color{green}202/202$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@PlaneshifterPlaneshifter added the bot: Update Copyright YearsPull request needing the copyright years of its files updated.label May 5, 2025
@stdlib-botstdlib-bot added bot: In ProgressPull request is currently awaiting automation.and removed bot: Update Copyright YearsPull request needing the copyright years of its files updated.labels May 5, 2025
@stdlib-botstdlib-bot added the Good First PRA pull request resolving a Good First Issue.label May 5, 2025
@PlaneshifterPlaneshifter removed the bot: In ProgressPull request is currently awaiting automation.label May 5, 2025
Planeshifter
Planeshifter requested changes May 5, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be refactored to have the parameters of the distribution be typed as int_32 instead of double; see other packages in https://.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/hypergeometric for reference.

@PlaneshifterPlaneshifter added the bot: Update Copyright YearsPull request needing the copyright years of its files updated.label May 10, 2025
@stdlib-botstdlib-bot added bot: In ProgressPull request is currently awaiting automation.and removed bot: Update Copyright YearsPull request needing the copyright years of its files updated.labels May 10, 2025
@Planeshifter
refactor: use int32_t instead of double for hypergeometric distributi…
28eae56
…on parameters

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter
Merge branch 'develop' into hypergeometric_mean
ebeac36
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: add trailing newline
8a8ef91
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: add trailing newline
25b4ff4
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
style: only keep one newline
5d5a913
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
docs: update examples
13a1ad3
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
docs: fix section tags
519a510
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Jun 18, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to land; thanks, @manvith2003!

@PlaneshifterPlaneshifter added the Ready To MergeA pull request which is ready to be merged.label Jun 18, 2025
@stdlib-botstdlib-bot removed the Needs ReviewA pull request which needs code review.label Jun 18, 2025
@stdlib-bot

PR Commit Message

feat: add C implementation for `stats/base/dists/hypergeometric/mean`

PR-URL: https://.com/stdlib-js/stdlib/pull/4193
Closes: https://.com/stdlib-js/stdlib/issues/3662

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@PlaneshifterPlaneshifter merged commit 0498764 into stdlib-js:develop Jun 18, 2025
29 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@Planeshifter Planeshifter Planeshifter approved these changes

No one assigned
bot: In ProgressPull request is currently awaiting automation.Good First PRA pull request resolving a Good First Issue.Ready To MergeA pull request which is ready to be merged.StatisticsIssue or pull request related to statistical functionality.
None yet
No milestone

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/hypergeometric/mean