Conversation

DhruvArvindSingh

Resolves #3736 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds C impelmentation for @stdlib/stats/base/dists/logistic/logcdf.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@DhruvArvindSingh
feat: add c implementation for @stdlib/stats/base/dists/logistic/logcdf
145cc72
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-botstdlib-bot added StatisticsIssue or pull request related to statistical functionality.Needs ReviewA pull request which needs code review.labels Dec 30, 2024
@DhruvArvindSingh
fix(main.c): made changes in main.c
fca081c
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot

Coverage Report

PackageStatementsBranchesFunctionsLines
stats/base/dists/logistic/logcdf$\color{green}352/352$
$\color{green}+100.00\%$		$\color{green}31/31$
$\color{green}+100.00\%$		$\color{green}5/5$
$\color{green}+100.00\%$		$\color{green}352/352$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@PlaneshifterPlaneshifter added the Potential DuplicateThere might be another pull request resolving the same issue.label Mar 15, 2025
@Planeshifter

⚠️Tracking Issue Closure Warning⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. automatically closes issues with such closing keywords when the PR is merged.

Required action:
Use "Progresses:" or "Ref:" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@Planeshifter

/stdlib update-copyright-years

@stdlib-botstdlib-bot added the bot: In ProgressPull request is currently awaiting automation.label Mar 31, 2025
@stdlib-botstdlib-bot added Good First PRA pull request resolving a Good First Issue.and removed bot: In ProgressPull request is currently awaiting automation.labels Mar 31, 2025
@Planeshifter
Merge branch 'develop' into develop_#3736
1593534
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: minor clean-up
612293d
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter
docs: add Doxygen comment
3e9122c
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
fix: add missing static keyword
894d9fe
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Jun 16, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to land.

@PlaneshifterPlaneshifter added Ready To MergeA pull request which is ready to be merged.labels Jun 16, 2025
@stdlib-botstdlib-bot removed the Needs ReviewA pull request which needs code review.label Jun 16, 2025
@stdlib-bot

PR Commit Message

feat: add c implementation for `@stdlib/stats/base/dists/logistic/logcdf`

PR-URL: https://.com/stdlib-js/stdlib/pull/4380
Closes: https://.com/stdlib-js/stdlib/issues/3736
Ref: https://.com/stdlib-js/stdlib/issues/3692

Co-authored-by: DhruvArvindSingh <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

⚠️Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@PlaneshifterPlaneshifter merged commit 3788752 into stdlib-js:develop Jun 16, 2025
46 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@Planeshifter Planeshifter Planeshifter approved these changes

No one assigned
Good First PRA pull request resolving a Good First Issue.Potential DuplicateThere might be another pull request resolving the same issue.Ready To MergeA pull request which is ready to be merged.StatisticsIssue or pull request related to statistical functionality.
None yet
No milestone

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/logistic/logcdf