Conversation

ShabiShett07

Progresses #2039

Description

What is the purpose of this pull request?

This pull request:

  • includes the support for Javascript and obtains Fortran reference from this page

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-botstdlib-bot added BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS).First-time ContributorA pull request from a contributor who has never previously committed to the project repository.labels Feb 5, 2025
@stdlib-bot

Coverage Report

PackageStatementsBranchesFunctionsLines
blas/base/icamax$\color{green}231/231$
$\color{green}+100.00\%$		$\color{green}15/15$
$\color{green}+100.00\%$		$\color{green}2/2$
$\color{green}+100.00\%$		$\color{green}231/231$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07

/stdlib lint-autofix

@stdlib-botstdlib-bot added the bot: In ProgressPull request is currently awaiting automation.label Feb 11, 2025
@ShabiShett07ShabiShett07 changed the title feat: add blas/base/icamax feat: add blas/base/icamax Feb 11, 2025
@ShabiShett07

/stdlib update-copyright-years

@stdlib-botstdlib-bot removed the bot: In ProgressPull request is currently awaiting automation.label Feb 11, 2025
@ShabiShett07ShabiShett07 marked this pull request as ready for review February 11, 2025 18:32
@stdlib-botstdlib-bot added the Needs ReviewA pull request which needs code review.label Feb 11, 2025
@ShabiShett07

@kgryte, Please do review this!

@stdlib-botstdlib-bot removed the First-time ContributorA pull request from a contributor who has never previously committed to the project repository.label Feb 16, 2025
@aman-095

/stdlib merge

@stdlib-botstdlib-bot added the bot: In ProgressPull request is currently awaiting automation.label Feb 19, 2025
@aman-095

/stdlib update-copyright-years

@stdlib-botstdlib-bot removed the bot: In ProgressPull request is currently awaiting automation.label Feb 19, 2025
@aman-095aman-095 added the FeatureIssue or pull request for adding a new feature.label Feb 19, 2025
@aman-095

Use Progresses in the description, Resolves will automatically close the issue associated with #2039 once this PR gets merged.

@aman-095
Update package.json
aefb83a
Check for the indentation and brackets. 

Signed-off-by: Aman Bhansali <[email protected]>
@ShabiShett07

Use Progresses in the description, Resolves will automatically close the issue associated with #2039 once this PR gets merged.

Thank you Aman sir for making the necessary changes in this PR.

May I know is this PR ready for merge?

@aman-095
Update README.md
ea43236
Signed-off-by: Aman Bhansali <[email protected]>
aman-095
aman-095 requested changes Feb 19, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update variable for index from icx to idx.

@aman-095aman-095 removed the Needs ReviewA pull request which needs code review.label Feb 19, 2025
aman-095
aman-095 reviewed Feb 19, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Left an initial set of comments.

@ShabiShett07
fix: resolved errors
ec7efeb
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@ShabiShett07
fix: resolved errors
61c28cf
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@ShabiShett07

Hello @aman-095 sir, thank you for suggesting the changes and made the necessary changes. Please do check.

@stdlib-botstdlib-bot added the Needs ReviewA pull request which needs code review.label Feb 23, 2025
@ShabiShett07

cc: @kgryte @Planeshifter

@kgryte

/stdlib merge

@stdlib-botstdlib-bot added the bot: In ProgressPull request is currently awaiting automation.label Apr 22, 2025
@stdlib-botstdlib-bot removed the bot: In ProgressPull request is currently awaiting automation.label Apr 22, 2025
ShabiShett07 and others added 6 commits April 23, 2025 10:23
@ShabiShett07
chore: update implementation
a6b105b
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
chore: update variable name
eb6d0b0
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: update implementation
117f26e
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: update implementation
a0e1f2e
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: add ndarray example
ff25470
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: minor clean-up
2486f5f
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07

/stdlib merge

@stdlib-botstdlib-bot added the bot: In ProgressPull request is currently awaiting automation.label Jun 13, 2025
@stdlib-botstdlib-bot removed the bot: In ProgressPull request is currently awaiting automation.label Jun 13, 2025
@ShabiShett07
chore: minor clean-up
c218d94
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: minor clean-up
cfa22e8
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: minor clean-up
4e71757
Signed-off-by: Shabareesh Shetty <[email protected]>
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@aman-095 aman-095 Awaiting requested review from aman-095

Requested changes must be addressed to merge this pull request.

No one assigned
BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS).FeatureIssue or pull request for adding a new feature.Needs ReviewA pull request which needs code review.
None yet
No milestone

Successfully merging this pull request may close these issues.