Conversation

thedeeppp

Resolves #5688

Description

What is the purpose of this pull request?

This pull request:

  • added implementation of accessor array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

I have doubt regarding test file, as you have mentioned in my previous PR (I closed that) I have to implement it using another folders but there are no test files for accessor array implementation so I got confused.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-botstdlib-bot added StatisticsIssue or pull request related to statistical functionality.First-time ContributorA pull request from a contributor who has never previously committed to the project repository.Needs ReviewA pull request which needs code review.Good First PRA pull request resolving a Good First Issue.labels Mar 12, 2025
@thedeeppp

@kgryte I have implemented accessor array part referring other implementations, but I have doubt regarding test file as there are no test files for the same.
please let me know for further changes.

@stdlib-bot

Coverage Report

PackageStatementsBranchesFunctionsLines
stats/base/variancech$\color{green}342/342$
$\color{green}+100.00\%$		$\color{green}18/18$
$\color{green}+100.00\%$		$\color{green}3/3$
$\color{green}+100.00\%$		$\color{green}342/342$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-botstdlib-bot removed the First-time ContributorA pull request from a contributor who has never previously committed to the project repository.label Mar 13, 2025
@gururaj1512gururaj1512 changed the title added accessor array implementation feat: add support for accessor arrays and refactor stats/base/variancech Jun 13, 2025
@gururaj1512

/stdlib merge

@stdlib-botstdlib-bot added the bot: In ProgressPull request is currently awaiting automation.label Jun 13, 2025
@stdlib-botstdlib-bot removed the bot: In ProgressPull request is currently awaiting automation.label Jun 13, 2025
gururaj1512 and others added 5 commits June 13, 2025 13:16
@gururaj1512
chore: update documentation and clean up empty files
d80e4cb
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: update parameter names and improve documentation for variancech …
87ed765
…functions

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@gururaj1512
test: add accessors tests for population and sample variance calculat…
528ebd6
…ions

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: correct formatting in example documentation for variancech
60d8a94
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
Update repl.txt
aaf5f5c
Signed-off-by: Gururaj Gurram <[email protected]>
gururaj1512
gururaj1512 previously approved these changes Jun 13, 2025
View reviewed changes
@gururaj1512gururaj1512 requested a review from kgryte June 13, 2025 13:40
kgryte
kgryte reviewed Jun 13, 2025
View reviewed changes
kgryte
kgryte approved these changes Jun 13, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgrytekgryte removed the Needs ReviewA pull request which needs code review.label Jun 13, 2025
@kgrytekgryte merged commit b711c6c into stdlib-js:develop Jun 13, 2025
12 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@kgryte kgryte kgryte approved these changes

@gururaj1512 gururaj1512 gururaj1512 left review comments

No one assigned
Good First PRA pull request resolving a Good First Issue.StatisticsIssue or pull request related to statistical functionality.
None yet
No milestone

Successfully merging this pull request may close these issues.

[RFC]: refactor and add protocol support to stats/base/variancech