Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Shabareesh Shetty <[email protected]>
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
#### scasum.Module..main( N, xp, sx ) | ||
Computes the sum of absolute values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is incomplete. See above.
#### scasum.Module..ndarray( N, xp, sx, ox ) | ||
Computes the sum of absolute values using alternative indexing semantics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is incomplete. See above.
// Reallocate the underlying memory to allow storing one vector: | ||
nb = bytesPerElement( options.dtype ); | ||
mod.realloc( (N*nb)+nb ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mod.realloc( (N*nb)+nb ); | |
mod.realloc( N*nb ); |
// Reallocate the underlying memory to allow storing one vector: | ||
nb = bytesPerElement( options.dtype ); | ||
mod.realloc( (N*nb)+nb ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mod.realloc( (N*nb)+nb ); | |
mod.realloc( N*nb ); |
// Define a pointer (i.e., byte offset) for storing the input vector: | ||
xptr = 0; | ||
x = new Complex64Array( uniform( N, -10.0, 10.0, options ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x = new Complex64Array( uniform( N, -10.0, 10.0, options ) ); | |
// Generate an array of random complex numbers: | |
x = new Complex64Array( uniform( N, -10.0, 10.0, options ) ); |
// Define a pointer (i.e., byte offset) for storing the input vector: | ||
xptr = 0; | ||
x = new Complex64Array( uniform( N, -10.0, 10.0, options ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x = new Complex64Array( uniform( N, -10.0, 10.0, options ) ); | |
// Generate an array of random complex numbers: | |
x = new Complex64Array( uniform( N, -10.0, 10.0, options ) ); |
> s = {{alias}}.main( 2, x, 2 ) | ||
7.0 | ||
// Use view offset; e.g., starting at 2nd element: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Use view offset; e.g., starting at 2nd element: | |
// Using typed array views: |
Don't go rogue. Be consistent with other packages.
7.0 | ||
// Use view offset; e.g., starting at 2nd element: | ||
> var x0 = new {{alias:@stdlib/array/complex64}}([1.0,-2.0,3.0,-4.0,5.0,-6.0,7.0,-8.0 ]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> var x0 = new {{alias:@stdlib/array/complex64}}([1.0,-2.0,3.0,-4.0,5.0,-6.0,7.0,-8.0 ]); | |
> var x0 = new {{alias:@stdlib/array/complex64}}( [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ] ); |
> s = {{alias}}.main( 2, x1, 2 ) | ||
22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> s = {{alias}}.main( 2, x1, 2 ) | |
22.0 | |
> s = {{alias}}.main( 2, x1, 1 ) | |
18.0 |
components of a single-precision complex floating-point vector | ||
using alternative indexing semantics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text wrapping is off.
> var s = {{alias}}.ndarray( x.length, x, 1, 0 ) | ||
15.0 | ||
// Using offset parameter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Using offset parameter: | |
// Advanced indexing: |
{{alias}}.Module..ndarray( N, xp, sx, ox ) | ||
Computes the sum of the absolute values of the real and imaginary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your text wrapping is off here. Everything should be wrapped to 80 chars. Meaning components
should be moved up and everything rewrapped. Please check the other descriptions in this file.
* // Specify a vector length: | ||
* var N = 4; | ||
* | ||
* // Define pointer (i.e., byte offsets) for storing two vectors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* // Define pointer (i.e., byte offsets) for storing two vectors: | |
* // Define a pointer (i.e., byte offset) for storing one vector: |
* // Specify a vector length: | ||
* var N = 4; | ||
* | ||
* // Define pointer (i.e., byte offsets) for storing two vectors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment.
* // Specify a vector length: | ||
* var N = 4; | ||
* | ||
* // Define pointer (i.e., byte offsets) for storing the input vector: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* // Define pointer (i.e., byte offsets) for storing the input vector: | |
* // Define a pointer (i.e., byte offset) for storing one input vector: |
This and similar changes throughout this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left an initial comments after reviewing a few files. I suggest going back through and doing a line-by-line check to ensure that everything is cleaned up.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Progresses: 2039
Description
This pull request:
blas/base/wasm/scasum
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers