Conversation

anandkaranubc

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

  • Adds the complete implementation for math/base/special/modff

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
feat: add math/base/special/modff
49ae7c8
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-botstdlib-bot added MathIssue or pull request specific to math functionality.Needs ReviewA pull request which needs code review.labels May 26, 2025
@stdlib-bot

Coverage Report

PackageStatementsBranchesFunctionsLines
math/base/special/modff$\color{green}285/285$
$\color{green}+100.00\%$		$\color{green}21/21$
$\color{green}+100.00\%$		$\color{green}3/3$
$\color{green}+100.00\%$		$\color{green}285/285$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubcanandkaranubc added FeatureIssue or pull request for adding a new feature.JavaScriptIssue involves or relates to JavaScript.CIssue involves or relates to C.GSoCGoogle Summer of Code.gsoc: 2025Google Summer of Code (2025).labels May 26, 2025
@anandkaranubc

FreeBSD implementation has similar logic.

https://.com/freebsd/freebsd-src/blob/main/lib/msun/src/s_modff.c

@anandkaranubc
Update benchmark.native.js
450de4c
Signed-off-by: Karan Anand <[email protected]>
@anandkaranubcanandkaranubc mentioned this pull request Jun 2, 2025
Open
@anandkaranubc
Merge branch 'develop' into feat/modff
20dc4ad
@anandkaranubc
bench: use random_uniform
cf29cb9
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter
Planeshifter reviewed Jun 13, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 13, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 13, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 13, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 13, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 13, 2025
View reviewed changes
Planeshifter
Planeshifter requested changes Jun 13, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In great shape overall, but noticed a few small things we should address.

@anandkaranubc
chore: remove duplicated entries from manifest.json
80d4ae3
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
Merge branch 'develop' into feat/modff
432187b
@anandkaranubc
refactor: use tuple for return type
2c660a2
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
chore: apply suggestions from review
dbed712
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter
Planeshifter approved these changes Jun 14, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @anandkaranubc!

@PlaneshifterPlaneshifter added the Ready To MergeA pull request which is ready to be merged.label Jun 14, 2025
@stdlib-botstdlib-bot removed the Needs ReviewA pull request which needs code review.label Jun 14, 2025
@stdlib-bot

PR Commit Message

feat: add `math/base/special/modff`

PR-URL: https://.com/stdlib-js/stdlib/pull/7101
Ref: https://.com/stdlib-js/stdlib/issues/649

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>

Please review the above commit message and make any necessary adjustments.

⚠️Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

@PlaneshifterPlaneshifter merged commit 23b6d1a into stdlib-js:develop Jun 14, 2025
29 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@kgryte kgryte kgryte left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

No one assigned
CIssue involves or relates to C.FeatureIssue or pull request for adding a new feature.GSoCGoogle Summer of Code.gsoc: 2025Google Summer of Code (2025).JavaScriptIssue involves or relates to JavaScript.MathIssue or pull request specific to math functionality.Ready To MergeA pull request which is ready to be merged.
None yet
No milestone

Successfully merging this pull request may close these issues.