Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/complex/float64/conj/benchmark/benchmark.js Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
@@ -33,7 +39,7 @@ | |||
* // returns <Complex128>[ 5.0, -3.0 ] | |||
*/ | |||
function conj( z ) { | |||
return new z.constructor( z.re, -z.im ); | |||
return new Complex128( real( z ), -imag( z ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this makes sense now. There is some history here in why z.constructor
was used. Namely, when this package was complex/conj
, we wanted to preserve input instance type. However, now that this package is in complex/float64
, I think we are fine always returning a Complex128
instance.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
@ShabiShett07 In order for the native add-on to compile, you need to add the |
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Added gyp files to this, just needed confirmation for the structure and got it from @kgryte |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Athan <[email protected]>
complex/float64/conj
complex/float64/conj
40373c5
into stdlib-js:develop Uh oh!
There was an error while loading. Please reload this page.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
none
Description
This pull request:
complex/float64/conj
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers