Conversation

Lokeshranjan8

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: na
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #7327.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a linting issue in cmd.js where new Array() was used.
  • Replaces it with array literal syntax [] to comply with eslint-plugin-stdlib lint rule: stdlib/no-new-array.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-botstdlib-bot added ToolsIssue or pull request related to project tooling.First-time ContributorA pull request from a contributor who has never previously committed to the project repository.Needs ReviewA pull request which needs code review.Good First PRA pull request resolving a Good First Issue.labels Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after I updated to actually use the .push method as instructed in the lint error message.

@kgrytekgryte removed the Needs ReviewA pull request which needs code review.label Jun 13, 2025
@kgrytekgryte merged commit d3ea1da into stdlib-js:develop Jun 13, 2025
8 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment
First-time ContributorA pull request from a contributor who has never previously committed to the project repository.Good First PRA pull request resolving a Good First Issue.ToolsIssue or pull request related to project tooling.
None yet

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors