close: sveltejs/eslint-plugin-svelte#1159
close: sveltejs/eslint-plugin-svelte#1158

🦋 Changeset detected

Latest commit: b2abfa0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
svelte-eslint-parser

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@692

Published Instant Preview Packages:

• svelte-eslint-parser: https://pkg.pr.new/svelte-eslint-parser@692

View Commit

Pull Request Test Coverage Report for Build 14086358686

Details

• 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.004%) to 94.659%

---

Totals
Change from base Build 14050456749:	0.004%
Covered Lines:	10478
Relevant Lines:	10945

---

💛 - Coveralls

I confirmed this PR fixes both issues in my project.

LGTM! Thank you!

@baseballyama Hello~

I think the fix might accidentally break and ignore the situation when the name of the store in v4 happens to be the same as the name of runes in v5.

For example, the $state store used by the project in v4 is now considered runes, causes a lot of false positives:

This statement is not reactive because all variables referenced in the reactive statement are immutable. eslint (svelte/no-immutable-reactive-statements)

I know I can fix my issue by refactoring the v4 store name, it just took me a little while to locate the changes causes this, so I'm leave a feedback here.