Conversation

czechboy0

Motivation

AHC transport changes of the approved proposals apple/swift-openapi-generator#255 and apple/swift-openapi-generator#254.

Modifications

  • Adapts to the runtime changes, depends on HTTPTypes now.
  • Both request and response works.

Result

Transport works with the 0.3.0 runtime API of.

Test Plan

Adapted tests.

@czechboy0czecy0 changed the title [WIP] [AHC Transport] Async bodies + swift-http-types adoption [AHC Transport] Async bodies + swift-http-types adoption Sep 18, 2023
@czechboy0czecy0 marked this pull request as ready for review September 18, 2023 13:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll hold off approving until we land runtime.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dnadoba ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czechboy0czecy0 merged commit 0a0c648 into swift-server:main Sep 27, 2023
@czechboy0czecy0 deleted the hd-adopt-http-types branch September 27, 2023 15:58
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Investigate adopting swift-http-types Make request/response bodies an async sequence of bytes