Conversation

croensch

It's not really relevant to the Mime / Email docs because that will use Base64 by default.

I've tried to keep it short, i'm not sure it's good though.

See PR symfony/symfony#49587 and issue symfony/symfony#49315

@carsonbotcarsonbot added this to the 6.3 milestone Mar 4, 2023
@croenschcroensch mentioned this pull request Mar 4, 2023
Open
@OskarStarkOskarStark added the Waiting Code MergeDocs for features pending to be mergedlabel Mar 5, 2023
@carsonbotcarsonbot modified the milestones: 6.3, next Mar 5, 2023
croensch
croensch commented Mar 5, 2023
View reviewed changes
@OskarStark

Versionadded directive is missing.

Can you please use named parameters and remove the null, null? Thanks

@carsonbotcarsonbot changed the title [HttpClient] support overwriting form encoding [HttpClient][Mime] support overwriting form encoding May 7, 2023
croensch
croensch commented May 12, 2023
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark you think this wording is okay?

croensch
croensch commented May 13, 2023
View reviewed changes
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@OskarStark OskarStark OskarStark left review comments

No one assigned
HttpClient Mime Status: Needs Review Waiting Code MergeDocs for features pending to be merged
None yet
next

Successfully merging this pull request may close these issues.