Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I probably should have caught that. Thanks for checking up on this. |
oestrich added a commit that referenced this pull request Jan 21, 2014
Fix HTTP basic authentication header detection for cURL example
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Unfortunately there is a bug in my previous pull request #108.
Headers in specs are written with a
HTTP_prefix (e.g.HTTP_AUTHORIZATION), and given without alteration to theCurlclass (source).When generating the API documentation, headers for
Curlare set byClientBase(source), which includesHeaderswhich formats them nicely (e.g. "Authorization") (source).Therefore the spec is green, but the generated documentation does not show the username and password as desired. This pull request changes one line to use a regular expression to detect the authorization header, either written as
HTTP_AUTHORIZATIONorAuthorization.