Conversation

nicolaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a beneficial update. The project benefits greatly by pushing this one out.

Notably, the version number would need a new MAJOR version.
Semantic versioning

@schm

@nicolaa Thanks for the contribution. I hope this gets merged eventually.

Notably, the version number would need a new MAJOR version.

@cickes I don't think so. File.exist? is part of the core library since well before 2.0.0. https://ruby-doc.org/core-1.8.6/File.html#method-c-exist-3F So this change is in no way backwards incompatible.

@bf4

Looks like maybe https://.com/stitchfix/rspec_api_documentation is the active fork to follow?

@santib

@oestrich @jakehow what's the maintenance status of this gem? Are you looking for new maintainers? It'd be quite important to get this trivial PR merged 😬

Thanks 🙌

@apotema

@oestrich @jakehow could you please accept this PR

@bf4

We just upgraded to Ruby 3.3.0
We'll be building off the https://.com/stitchfix/rspec_api_documentation fork for now but might start our own or transition to rspec-openapi and rswag like others have

@vladveterok

Hey good fellas, is there a good reason this PR is still not being merged?
If the project is dead (which is a possibility considering the date of the last change made) no further questions will be asked :)
Thanks!
cc @oestrich @jakehow

@bf4

Project needs to be adopted

@santib

FWIW in https://.com/rootstrap/rails_api_base we migrated to:

More info in https://.com/rootstrap/rails_api_base/blob/main/docs/api_documentation.md

@apotema

These are some great libs @santib . But it would be good to have this lib back.

@jakehow

@vladveterok @bf4 lots of requests for maintenance and little volunteering to do it... I don't think this PR passed travisCI originally which is why it was not merged quickly. Travis now requires payment even on free plan which is probably why it's been removed. I am not sure if there is an alternative these days for OSS CI builds that is still free.

Happy to add anyone who wants to push some of these items forward ... @bf4 ?

@bf4

@jakehow Sure. I'll make a actions test matrix pr on Wednesday if no one else has yet. (I'm afk right now)

@bf4bf4 mentioned this pull request Apr 25, 2024
@bf4bf4 merged commit 6c6f651 into zipmark:master Apr 25, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.