Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Can this be merged? Can a new version be released? |
+1, can't upgrade rack because of this issue |
1 similar comment
+1, can't upgrade rack because of this issue |
interesting. Thanks for reporting this. We need to get CI passing too |
So you couldn't get CI passing for months? Everybody needs this fix to make it work with rack 3.1.x and this PR was opened 1 year ago... |
That is correct. So it goes in open source at times |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After moving to rack 3.1.x,
last_request.env["rack.input"]is returning nil ongetrequests. This will safely deal with that situation, replacing the return value with an empty string.