Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ner-json # Conflicts: # google-cloud-spanner/src/test/java/com/google/cloud/spanner/AbstractStructReaderTypesTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
olavloite approved these changes Apr 27, 2021
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITWriteTest.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITWriteTest.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
| } | ||
| @Test | ||
| public void bindJsonNull() { |
There was a problem hiding this comment.
nit: per convention we usually name the tests as testBindJsonNull
There was a problem hiding this comment.
this would make the JSON test names different from the other test names in this test class, is that okay?
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
…ner-json # Conflicts: # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java
…panner-json-test
…panner-json-test # Conflicts: # google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java # google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITWriteTest.java # proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TypeCode.java # proto-google-cloud-spanner-v1/src/main/proto/google/spanner/v1/type.proto
…nto spanner-json-test
Closing as I've added the tests into the implementation PR |
gcf-merge-on-green bot pushed a commit to googleapis/java-spanner that referenced this pull request Aug 24, 2021
Allow users to read and write to Cloud Spanner databases using the JSON type through the client libraries. Integration tests here: zoercai#1
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Integration Tests for the new JSON type, which allows users to read and write to Cloud Spanner databases using the JSON type through the client libraries.