Conversation

zoercai

Integration Tests for the new JSON type, which allows users to read and write to Cloud Spanner databases using the JSON type through the client libraries.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good to me, with a couple of nits for adding some additional values to the test cases.

}

@Test
public void bindJsonNull() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: per convention we usually name the tests as testBindJsonNull

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would make the JSON test names different from the other test names in this test class, is that okay?

zoercai added 3 commits May 3, 2021 14:45
…ner-json

# Conflicts:
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java
zoercai added 2 commits July 6, 2021 11:55
…panner-json-test

# Conflicts:
#	google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/GrpcResultSetTest.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/ValueTest.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java
#	google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITWriteTest.java
#	proto-google-cloud-spanner-v1/src/main/java/com/google/spanner/v1/TypeCode.java
#	proto-google-cloud-spanner-v1/src/main/proto/google/spanner/v1/type.proto
@zoercai

Closing as I've added the tests into the implementation PR

@zoercaizoercai closed this Jul 6, 2021
gcf-merge-on-green bot pushed a commit to googleapis/java-spanner that referenced this pull request Aug 24, 2021
Allow users to read and write to Cloud Spanner databases using the JSON type through the client libraries.

Integration tests here: zoercai#1
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.