Conversation

backrunner

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Webpack also provides two configuration items named http2 and devServer.server, if http2 is set to true, the dev server will also start with HTTPS, and it's the same for devServer.server is set to https or spdy.

The current code only judgement whether projectDevServerOptions.https is a truthy value, this is an inaccurate judgement.

This contains changes that cover more cases than the existing code, allowing users to get correct URLs after executing vue-cli-service serve.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haoqunjianghaoqunjiang merged commit bddd64d into vuejs:dev Jul 4, 2022
@backrunner

@sodatea Your commit 558dea2 suddenly reminded me that my fix is not perfect. devServer.server.type is not included in the judgement, I'll create another to cover that case.
If you have time now, you can complete this judgement first. Sorry for this fix isn't perfect.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.