Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
136737c to d21a108 Compare .gitignore Outdated
| lib/**/* | ||
| .idea |
There was a problem hiding this comment.
Nitpick: would be good to add a newline here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| @@ -17,6 +17,9 @@ export async function runOnBlame(files: string[]): Promise<void> { | |||
| core.getInput('phpcs_path', { required: true }) | |||
| ); | |||
| const dontFailOnError = | |||
| core.getInput('fail_on_errors') == 'false' || | |||
| core.getInput('fail_on_errors') === 'off'; | |||
There was a problem hiding this comment.
Not really great to use double negatives in variable names, but given that dontFailOnWarning already exists, meh.
Although given that this is later only used as !dontFailOnError I think it's actually better to simply name it failOnError.
There was a problem hiding this comment.
I agree but the original author already had this, I only intended to add a "copy" which works the same as the warning option.
| const failOnError = core.getInput('fail_on_errors'); | ||
| if (failOnError == 'false' || failOnError === 'off') { | ||
| args.push('--runtime-set ignore_errors_on_exit 1'); | ||
| } | ||
| const failOnWarning = core.getInput('fail_on_warnings'); |
There was a problem hiding this comment.
Such consistency by the original author...
Updated the npm packages. This commit can be removed when the upstream action works again. Afterwards run `npm install && npm run all`.
eldering approved these changes Feb 23, 2021
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This version will not break on errors or warnings.