Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test suite needs to run with ES 8 on this branch but I'm not familiar enough with it to make the right change. |
Without having a deeper look into it I'd say replace all occurences of |
Closed
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In addition to pinning v8 of
elasticsearch-ruby, there were two other things I had to consider.ES 8 does not allow sending a document type. I followed previous work in this repo and used
Hash#compactto remove thetypeparam.elasticsearch-rubyv8 uses the newelastic-transportgem instead of the olderelasticsearch-transportone. I added a (hopefully) backwards compatible solution viaELASTIC_TRANSPORT_CLASS.