Resolved / Related Issues

• Code Quality: Replace Vanara with CsWin32 #15000

Steps used to test these changes

1. Open Files app
2. Enable the setting to run Files in the background
3. Start debebugging Files
4. Close the window
5. Launch Files from Start Menu

Requesting your review @dongle-the-gadget @hez2010

[dongle-the-gadget]

Do you even need to allocate a stack here? I thought your HANDLE variable is in stack already.

[0x5bfa]

Related to your 2nd comment, it looks like you can't take address of a local variable that goes thru an async lambda/function. The current code doesn't have async and initially did so this can be refactored but IIUC if we wanna use async void we may have to do this.

[dongle-the-gadget]

Is there a reason why async void isn't desirable here?

[0x5bfa]

So you mean adding Wait() in that helper method instead?

[dongle-the-gadget]

I mean making it an async lambda and then await.

[0x5bfa]

Id like to keep this PR's scope just wrapping the unsafe code into a separate method.

Ready

I think it's better to do something like

public Task Something(Task task)
{
    async Task Call()
    {
        await task;
        SetEvent();
    }
}