Conversation

olavloite

Google Cloud Spanner now supports Foreign Key Constraints. These now also show up in the corresponding DatabaseMetaData methods.

Fixes #77

@olavloite
feat: add support for foreign keys
914bb01
Google Cloud Spanner now supports Foreign Key Constraints. These now
also show up in the corresponding DatabaseMetaData methods.

Fixes #77
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Mar 6, 2020
skuruppu
skuruppu approved these changes Mar 9, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will admit that I'm not too familiar with the JDBC driver test setup with the generated SQL queries but the schema you had setup in the ITs looks reasonable and so do the tests.

@olavloiteolavloite merged commit 9e770f2 into master Mar 9, 2020
@olavloiteolavloite deleted the foreign-keys branch March 9, 2020 15:25
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 18, 2020
@release-please
chore: release 1.14.0 (#82)
0060224
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.14.0](https://www..com/googleapis/java-spanner-jdbc/compare/v1.13.0...v1.14.0) (2020-03-18)


### Features

* add support for foreign keys ([#78](https://www..com/googleapis/java-spanner-jdbc/issues/78)) ([9e770f2](https://www..com/googleapis/java-spanner-jdbc/commit/9e770f281c03a1e9c034e5ff3ddee44fa20a7b30)), closes [#77](https://www..com/googleapis/java-spanner-jdbc/issues/77)


### Bug Fixes

* add missing netty-shaded lib for über-jar ([#80](https://www..com/googleapis/java-spanner-jdbc/issues/80)) ([3d6f356](https://www..com/googleapis/java-spanner-jdbc/commit/3d6f35669671194e6772fe327ce48f27e5bf4643))
* fix deprecation warnings in JDBC (test) files ([#81](https://www..com/googleapis/java-spanner-jdbc/issues/81)) ([a5e031d](https://www..com/googleapis/java-spanner-jdbc/commit/a5e031d3183f8fe88a621500f235ca2b0242f50b))
* include Spanner gRPC test dependencies ([#63](https://www..com/googleapis/java-spanner-jdbc/issues/63)) ([a34bfc0](https://www..com/googleapis/java-spanner-jdbc/commit/a34bfc0ff1c2ddeef077dbfae4c56bdd53febcb2))


### Dependencies

* update core dependencies ([1ae098e](https://www..com/googleapis/java-spanner-jdbc/commit/1ae098e924c2a488cfddd0a3aee9511274b7a515))
* update core dependencies ([#40](https://www..com/googleapis/java-spanner-jdbc/issues/40)) ([18c3a1b](https://www..com/googleapis/java-spanner-jdbc/commit/18c3a1b069cb507a91d0320e64a8bf8ae8efe394))
* update core dependencies ([#73](https://www..com/googleapis/java-spanner-jdbc/issues/73)) ([cfa1539](https://www..com/googleapis/java-spanner-jdbc/commit/cfa153997599c36f1243e87f1ea0760694657dfe))
* update core dependencies to v1.27.1 ([#61](https://www..com/googleapis/java-spanner-jdbc/issues/61)) ([181991b](https://www..com/googleapis/java-spanner-jdbc/commit/181991bda1f66de707d27dad9658b9177626595a))
* update core dependencies to v1.27.2 ([#71](https://www..com/googleapis/java-spanner-jdbc/issues/71)) ([12425fc](https://www..com/googleapis/java-spanner-jdbc/commit/12425fcb4382449e4a7a0edad4c812b7ce15aa71))
* update core dependencies to v1.54.0 ([#72](https://www..com/googleapis/java-spanner-jdbc/issues/72)) ([5676021](https://www..com/googleapis/java-spanner-jdbc/commit/567602177e05fa198eaa011fbca05cfe4b72fb13))
* update core dependencies to v1.92.5 ([#53](https://www..com/googleapis/java-spanner-jdbc/issues/53)) ([604ee2b](https://www..com/googleapis/java-spanner-jdbc/commit/604ee2b75204ad52eaf724c3fb71e8c13540af7c))
* update core transport dependencies to v1.34.1 ([#43](https://www..com/googleapis/java-spanner-jdbc/issues/43)) ([2b6f04d](https://www..com/googleapis/java-spanner-jdbc/commit/2b6f04da3aeebac778fb664c4564fb8b58bf3be4))
* update core transport dependencies to v1.34.2 ([#62](https://www..com/googleapis/java-spanner-jdbc/issues/62)) ([8739015](https://www..com/googleapis/java-spanner-jdbc/commit/8739015f62289adb92fd55b19a5bff8762da20a9))
* update dependency com.google.api-client:google-api-client-bom to v1.30.8 ([#46](https://www..com/googleapis/java-spanner-jdbc/issues/46)) ([ef891b0](https://www..com/googleapis/java-spanner-jdbc/commit/ef891b000045d1f39f91b6a0ed3abaab19c5f05e))
* update dependency com.google.api-client:google-api-client-bom to v1.30.9 ([#74](https://www..com/googleapis/java-spanner-jdbc/issues/74)) ([3b62299](https://www..com/googleapis/java-spanner-jdbc/commit/3b622999b9f9645a6086e5efd3206f4d7b0806bc))
* update dependency com.google.truth:truth to v1.0.1 ([#32](https://www..com/googleapis/java-spanner-jdbc/issues/32)) ([5205863](https://www..com/googleapis/java-spanner-jdbc/commit/52058636e10951e883523204f0f161db8a972d62))
* update protobuf.version to v3.11.3 ([#48](https://www..com/googleapis/java-spanner-jdbc/issues/48)) ([0779fcb](https://www..com/googleapis/java-spanner-jdbc/commit/0779fcb0bfe935c3c302fa8442f733c7e3629761))
* update protobuf.version to v3.11.4 ([#64](https://www..com/googleapis/java-spanner-jdbc/issues/64)) ([f485cff](https://www..com/googleapis/java-spanner-jdbc/commit/f485cfffa0de27ce35f5d16c689c31c6ea22138e))
* update spanner.version to v1.51.0 ([#75](https://www..com/googleapis/java-spanner-jdbc/issues/75)) ([4fff168](https://www..com/googleapis/java-spanner-jdbc/commit/4fff168eae61fb55933cf3afd67f24ca65dfde54))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Mar 25, 2020
@yoshi-automation
chore: release 1.14.0 (#82)
f42ea47
0060224
commit 0060224
Author: release-please[bot] <55107282+release-please[bot]@users.noreply..com>
Date:   Wed Mar 18 23:22:08 2020 +0000

    chore: release 1.14.0 (#82)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [1.14.0](https://www..com/googleapis/java-spanner-jdbc/compare/v1.13.0...v1.14.0) (2020-03-18)

    ### Features

    * add support for foreign keys ([#78](https://www..com/googleapis/java-spanner-jdbc/issues/78)) ([9e770f2](https://www..com/googleapis/java-spanner-jdbc/commit/9e770f281c03a1e9c034e5ff3ddee44fa20a7b30)), closes [#77](https://www..com/googleapis/java-spanner-jdbc/issues/77)

    ### Bug Fixes

    * add missing netty-shaded lib for über-jar ([#80](https://www..com/googleapis/java-spanner-jdbc/issues/80)) ([3d6f356](https://www..com/googleapis/java-spanner-jdbc/commit/3d6f35669671194e6772fe327ce48f27e5bf4643))
    * fix deprecation warnings in JDBC (test) files ([#81](https://www..com/googleapis/java-spanner-jdbc/issues/81)) ([a5e031d](https://www..com/googleapis/java-spanner-jdbc/commit/a5e031d3183f8fe88a621500f235ca2b0242f50b))
    * include Spanner gRPC test dependencies ([#63](https://www..com/googleapis/java-spanner-jdbc/issues/63)) ([a34bfc0](https://www..com/googleapis/java-spanner-jdbc/commit/a34bfc0ff1c2ddeef077dbfae4c56bdd53febcb2))

    ### Dependencies

    * update core dependencies ([1ae098e](https://www..com/googleapis/java-spanner-jdbc/commit/1ae098e924c2a488cfddd0a3aee9511274b7a515))
    * update core dependencies ([#40](https://www..com/googleapis/java-spanner-jdbc/issues/40)) ([18c3a1b](https://www..com/googleapis/java-spanner-jdbc/commit/18c3a1b069cb507a91d0320e64a8bf8ae8efe394))
    * update core dependencies ([#73](https://www..com/googleapis/java-spanner-jdbc/issues/73)) ([cfa1539](https://www..com/googleapis/java-spanner-jdbc/commit/cfa153997599c36f1243e87f1ea0760694657dfe))
    * update core dependencies to v1.27.1 ([#61](https://www..com/googleapis/java-spanner-jdbc/issues/61)) ([181991b](https://www..com/googleapis/java-spanner-jdbc/commit/181991bda1f66de707d27dad9658b9177626595a))
    * update core dependencies to v1.27.2 ([#71](https://www..com/googleapis/java-spanner-jdbc/issues/71)) ([12425fc](https://www..com/googleapis/java-spanner-jdbc/commit/12425fcb4382449e4a7a0edad4c812b7ce15aa71))
    * update core dependencies to v1.54.0 ([#72](https://www..com/googleapis/java-spanner-jdbc/issues/72)) ([5676021](https://www..com/googleapis/java-spanner-jdbc/commit/567602177e05fa198eaa011fbca05cfe4b72fb13))
    * update core dependencies to v1.92.5 ([#53](https://www..com/googleapis/java-spanner-jdbc/issues/53)) ([604ee2b](https://www..com/googleapis/java-spanner-jdbc/commit/604ee2b75204ad52eaf724c3fb71e8c13540af7c))
    * update core transport dependencies to v1.34.1 ([#43](https://www..com/googleapis/java-spanner-jdbc/issues/43)) ([2b6f04d](https://www..com/googleapis/java-spanner-jdbc/commit/2b6f04da3aeebac778fb664c4564fb8b58bf3be4))
    * update core transport dependencies to v1.34.2 ([#62](https://www..com/googleapis/java-spanner-jdbc/issues/62)) ([8739015](https://www..com/googleapis/java-spanner-jdbc/commit/8739015f62289adb92fd55b19a5bff8762da20a9))
    * update dependency com.google.api-client:google-api-client-bom to v1.30.8 ([#46](https://www..com/googleapis/java-spanner-jdbc/issues/46)) ([ef891b0](https://www..com/googleapis/java-spanner-jdbc/commit/ef891b000045d1f39f91b6a0ed3abaab19c5f05e))
    * update dependency com.google.api-client:google-api-client-bom to v1.30.9 ([#74](https://www..com/googleapis/java-spanner-jdbc/issues/74)) ([3b62299](https://www..com/googleapis/java-spanner-jdbc/commit/3b622999b9f9645a6086e5efd3206f4d7b0806bc))
    * update dependency com.google.truth:truth to v1.0.1 ([#32](https://www..com/googleapis/java-spanner-jdbc/issues/32)) ([5205863](https://www..com/googleapis/java-spanner-jdbc/commit/52058636e10951e883523204f0f161db8a972d62))
    * update protobuf.version to v3.11.3 ([#48](https://www..com/googleapis/java-spanner-jdbc/issues/48)) ([0779fcb](https://www..com/googleapis/java-spanner-jdbc/commit/0779fcb0bfe935c3c302fa8442f733c7e3629761))
    * update protobuf.version to v3.11.4 ([#64](https://www..com/googleapis/java-spanner-jdbc/issues/64)) ([f485cff](https://www..com/googleapis/java-spanner-jdbc/commit/f485cfffa0de27ce35f5d16c689c31c6ea22138e))
    * update spanner.version to v1.51.0 ([#75](https://www..com/googleapis/java-spanner-jdbc/issues/75)) ([4fff168](https://www..com/googleapis/java-spanner-jdbc/commit/4fff168eae61fb55933cf3afd67f24ca65dfde54))
    ---

    This PR was generated with [Release Please](https://.com/googleapis/release-please).

CHANGELOG.md
README.md
pom.xml
versions.txt
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@skuruppu skuruppu skuruppu approved these changes

@hengfengli hengfengli Awaiting requested review from hengfengli

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.

DatabaseMetadata should return information about foreign keys