Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds generic ignore rules for added methods to interfaces in the generated code. Fixes #99
skuruppu approved these changes Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect. Thank you for the fix.
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 20, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.52.0](https://www..com/googleapis/java-spanner/compare/v1.51.0...v1.52.0) (2020-03-20) ### Features * add backup support ([#100](https://www..com/googleapis/java-spanner/issues/100)) ([ed3874a](https://www..com/googleapis/java-spanner/commit/ed3874afcf55fe7381354e03dab3a3b97d7eb520)) * add Backups protos and APIs ([#97](https://www..com/googleapis/java-spanner/issues/97)) ([5643c22](https://www..com/googleapis/java-spanner/commit/5643c22a4531dac75b9fac5b128eb714a27920a0)) ### Bug Fixes * add client id to metrics to avoid collisions ([#117](https://www..com/googleapis/java-spanner/issues/117)) ([338e136](https://www..com/googleapis/java-spanner/commit/338e136508edc6745f9371e8a5d66638021bc8d7)), closes [#106](https://www..com/googleapis/java-spanner/issues/106) * ignore added interface methods for generated code ([#101](https://www..com/googleapis/java-spanner/issues/101)) ([402cfa1](https://www..com/googleapis/java-spanner/commit/402cfa1e1e2994f7bb1b783cf823021b54fb175e)), closes [#99](https://www..com/googleapis/java-spanner/issues/99) * use grpc 1.27.2 to prevent version conflicts ([#105](https://www..com/googleapis/java-spanner/issues/105)) ([37b7c88](https://www..com/googleapis/java-spanner/commit/37b7c8859e5f35d85bd14ef72662614fd185c020)) ### Dependencies * update core dependencies ([#94](https://www..com/googleapis/java-spanner/issues/94)) ([f3ca4c9](https://www..com/googleapis/java-spanner/commit/f3ca4c99c3d54f64c5eda11e4a4c076140fdbc6a)) * update opencensus.version to v0.26.0 ([#116](https://www..com/googleapis/java-spanner/issues/116)) ([1b8db0b](https://www..com/googleapis/java-spanner/commit/1b8db0b407429e02bb1e4c9af839afeed21dac5d)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Mar 25, 2020
1d3c4ac commit 1d3c4ac Author: release-please[bot] <55107282+release-please[bot]@users.noreply..com> Date: Fri Mar 20 04:10:05 2020 +0000 chore: release 1.52.0 (#110) 🤖 I have created a release \*beep\* \*boop\* --- ## [1.52.0](https://www..com/googleapis/java-spanner/compare/v1.51.0...v1.52.0) (2020-03-20) ### Features * add backup support ([#100](https://www..com/googleapis/java-spanner/issues/100)) ([ed3874a](https://www..com/googleapis/java-spanner/commit/ed3874afcf55fe7381354e03dab3a3b97d7eb520)) * add Backups protos and APIs ([#97](https://www..com/googleapis/java-spanner/issues/97)) ([5643c22](https://www..com/googleapis/java-spanner/commit/5643c22a4531dac75b9fac5b128eb714a27920a0)) ### Bug Fixes * add client id to metrics to avoid collisions ([#117](https://www..com/googleapis/java-spanner/issues/117)) ([338e136](https://www..com/googleapis/java-spanner/commit/338e136508edc6745f9371e8a5d66638021bc8d7)), closes [#106](https://www..com/googleapis/java-spanner/issues/106) * ignore added interface methods for generated code ([#101](https://www..com/googleapis/java-spanner/issues/101)) ([402cfa1](https://www..com/googleapis/java-spanner/commit/402cfa1e1e2994f7bb1b783cf823021b54fb175e)), closes [#99](https://www..com/googleapis/java-spanner/issues/99) * use grpc 1.27.2 to prevent version conflicts ([#105](https://www..com/googleapis/java-spanner/issues/105)) ([37b7c88](https://www..com/googleapis/java-spanner/commit/37b7c8859e5f35d85bd14ef72662614fd185c020)) ### Dependencies * update core dependencies ([#94](https://www..com/googleapis/java-spanner/issues/94)) ([f3ca4c9](https://www..com/googleapis/java-spanner/commit/f3ca4c99c3d54f64c5eda11e4a4c076140fdbc6a)) * update opencensus.version to v0.26.0 ([#116](https://www..com/googleapis/java-spanner/issues/116)) ([1b8db0b](https://www..com/googleapis/java-spanner/commit/1b8db0b407429e02bb1e4c9af839afeed21dac5d)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please). CHANGELOG.md README.md google-cloud-spanner-bom/pom.xml google-cloud-spanner/pom.xml grpc-google-cloud-spanner-admin-database-v1/pom.xml grpc-google-cloud-spanner-admin-instance-v1/pom.xml grpc-google-cloud-spanner-v1/pom.xml pom.xml proto-google-cloud-spanner-admin-database-v1/pom.xml proto-google-cloud-spanner-admin-instance-v1/pom.xml proto-google-cloud-spanner-v1/pom.xml versions.txt
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://.com/googleapis/release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds generic ignore rules for added methods to interfaces in the generated code.
Fixes #99