Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SpannerRetryHelperTest.testExceptionWithRetryInfo could sometimes fail on some environments. I have not been able to reproduce it locally, but one possible reason for the failure could be truncation when converting from nanoseconds to milliseconds. Now both the timeout and the verification use nanosecond precision. This change also removes all uses of hamcres in this test file. Fixes #200
skuruppu approved these changes May 14, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request May 19, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.55.0](https://www..com/googleapis/java-spanner/compare/v1.54.0...v1.55.0) (2020-05-19) ### Features * mark when a Spanner client is closed ([#198](https://www..com/googleapis/java-spanner/issues/198)) ([50cb174](https://www..com/googleapis/java-spanner/commit/50cb1744e7ede611758d3ff63b3df77a1d3682eb)) ### Bug Fixes * make it possible to override backups methods ([#195](https://www..com/googleapis/java-spanner/issues/195)) ([2d19c25](https://www..com/googleapis/java-spanner/commit/2d19c25ba32847d116194565e67e1b1276fcb9f8)) * Partitioned DML timeout was not always respected ([#203](https://www..com/googleapis/java-spanner/issues/203)) ([13cb37e](https://www..com/googleapis/java-spanner/commit/13cb37e55ddfd1ff4ec22b1dcdc20c4832eee444)), closes [#199](https://www..com/googleapis/java-spanner/issues/199) * partitionedDml stub was not closed ([#213](https://www..com/googleapis/java-spanner/issues/213)) ([a2d9a33](https://www..com/googleapis/java-spanner/commit/a2d9a33fa31f7467fc2bfbef5a29c4b3f5aea7c8)) * reuse clientId for invalidated databases ([#206](https://www..com/googleapis/java-spanner/issues/206)) ([7b4490d](https://www..com/googleapis/java-spanner/commit/7b4490dfb61fbc81b5bd6be6c9a663b36b5ce402)) * use nanos to prevent truncation errors ([#204](https://www..com/googleapis/java-spanner/issues/204)) ([a608460](https://www..com/googleapis/java-spanner/commit/a60846043dc0ca47e1970d8ab99380b6d725c7a9)), closes [#200](https://www..com/googleapis/java-spanner/issues/200) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.3.1 ([#190](https://www..com/googleapis/java-spanner/issues/190)) ([ad41a0d](https://www..com/googleapis/java-spanner/commit/ad41a0d4b0cc6a2c0ae0611c767652f64cfb2fb7)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please).
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.1](https://www..com/googleapis/java-spanner-jdbc/compare/v1.17.0...v1.17.1) (2020-09-21) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([googleapis#199](https://www..com/googleapis/java-spanner-jdbc/issues/199)) ([59a7d07](https://www..com/googleapis/java-spanner-jdbc/commit/59a7d07c284210033bd1d587b09c44d9c271a52e)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
SpannerRetryHelperTest.testExceptionWithRetryInfo could sometimes fail on some environments. I have not been able to reproduce it locally, but one possible reason for the failure could be truncation when converting from nanoseconds to milliseconds. Now both the timeout and the verification use nanosecond precision.
This change also removes all uses of hamcrest in this test file.
Fixes #200