Conversation

olavloite

Aborted read/write transactions used static retry settings that were not coming from the gapic configuration. This PR changes that to using the default retry settings from the gapic configuration. As the default retry settings themselves are not accessible from the generated SpannerStubSettings class, the retry settings are taken from the configuration of the Rollback RPC, which is also linked with the default retry settings.

Updates #20

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 28, 2020
@olavloiteolavloite added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 28, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 28, 2020
skuruppu
skuruppu approved these changes Jan 30, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ok, that's an indirect way to get access to the settings but seems like this is the most reasonable way to do it.

@olavloiteolavloite merged commit 6709552 into master Jan 30, 2020
@olavloiteolavloite deleted the issue-20-aborted-tx branch January 30, 2020 11:06
@yoshi-automationyoshi-automation mentioned this pull request Jan 31, 2020
Merged
@olavloiteolavloite mentioned this pull request Feb 28, 2020
Closed
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@renovate-bot
deps: update protobuf.version to v3.11.3 (googleapis#48)
0779fcb
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@yoshi-automation
chore: update common templates
e6ec261
This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:
8739015 deps: update core transport dependencies to v1.34.2 (googleapis#62)
181991b deps: update core dependencies to v1.27.1 (googleapis#61)
a34bfc0 fix: include Spanner gRPC test dependencies (googleapis#63)
604ee2b deps: update core dependencies to v1.92.5 (googleapis#53)
1c676f4 build(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.2.2 (googleapis#55)
41236c4 chore: update  url (googleapis#56)
ce29139 chore: only allow renovate-bot for trusted-contribution auto-labeling
aad4ecf chore: release 1.13.1-SNAPSHOT (googleapis#51)
1ae098e deps: update core dependencies
ef891b0 deps: update dependency com.google.api-client:google-api-client-bom to v1.30.8 (googleapis#46)
0779fcb deps: update protobuf.version to v3.11.3 (googleapis#48)


<details><summary>Log from Synthtool</summary>

```
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
On branch autosynth
nothing to commit, working tree clean
HEAD detached at FETCH_HEAD
nothing to commit, working tree clean
./ISSUE_TEMPLATE/bug_report.md
./ISSUE_TEMPLATE/feature_request.md
./ISSUE_TEMPLATE/support_request.md
./PULL_REQUEST_TEMPLATE.md
./release-please.yml
.kokoro/build.bat
.kokoro/build.sh
.kokoro/coerce_logs.sh
.kokoro/common.cfg
.kokoro/continuous/common.cfg
.kokoro/continuous/dependencies.cfg
.kokoro/continuous/integration.cfg
.kokoro/continuous/java11.cfg
.kokoro/continuous/java7.cfg
.kokoro/continuous/java8-osx.cfg
.kokoro/continuous/java8-win.cfg
.kokoro/continuous/java8.cfg
.kokoro/continuous/lint.cfg
.kokoro/continuous/propose_release.cfg
.kokoro/continuous/propose_release.sh
.kokoro/continuous/samples.cfg
.kokoro/dependencies.sh
.kokoro/linkage-monitor.sh
.kokoro/nightly/common.cfg
.kokoro/nightly/dependencies.cfg
.kokoro/nightly/integration.cfg
.kokoro/nightly/java11.cfg
.kokoro/nightly/java7.cfg
.kokoro/nightly/java8-osx.cfg
.kokoro/nightly/java8-win.cfg
.kokoro/nightly/java8.cfg
.kokoro/nightly/lint.cfg
.kokoro/nightly/samples.cfg
.kokoro/presubmit/clirr.cfg
.kokoro/presubmit/common.cfg
.kokoro/presubmit/dependencies.cfg
.kokoro/presubmit/integration.cfg
.kokoro/presubmit/java11.cfg
.kokoro/presubmit/java7.cfg
.kokoro/presubmit/java8-osx.cfg
.kokoro/presubmit/java8-win.cfg
.kokoro/presubmit/java8.cfg
.kokoro/presubmit/linkage-monitor.cfg
.kokoro/presubmit/lint.cfg
.kokoro/presubmit/samples.cfg
.kokoro/release/bump_snapshot.cfg
.kokoro/release/bump_snapshot.sh
.kokoro/release/common.cfg
.kokoro/release/common.sh
.kokoro/release/drop.cfg
.kokoro/release/drop.sh
.kokoro/release/promote.cfg
.kokoro/release/promote.sh
.kokoro/release/publish_javadoc.cfg
.kokoro/release/publish_javadoc.sh
.kokoro/release/snapshot.cfg
.kokoro/release/snapshot.sh
.kokoro/release/stage.cfg
.kokoro/release/stage.sh
.kokoro/trampoline.sh
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
java.header
license-checks.xml
renovate.json
synthtool > Wrote metadata to synth.metadata.

```
</details>
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@release-please
chore: release 1.14.0 (googleapis#82)
0060224
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.14.0](https://www..com/googleapis/java-spanner-jdbc/compare/v1.13.0...v1.14.0) (2020-03-18)


### Features

* add support for foreign keys ([googleapis#78](https://www..com/googleapis/java-spanner-jdbc/issues/78)) ([9e770f2](https://www..com/googleapis/java-spanner-jdbc/commit/9e770f281c03a1e9c034e5ff3ddee44fa20a7b30)), closes [googleapis#77](https://www..com/googleapis/java-spanner-jdbc/issues/77)


### Bug Fixes

* add missing netty-shaded lib for über-jar ([googleapis#80](https://www..com/googleapis/java-spanner-jdbc/issues/80)) ([3d6f356](https://www..com/googleapis/java-spanner-jdbc/commit/3d6f35669671194e6772fe327ce48f27e5bf4643))
* fix deprecation warnings in JDBC (test) files ([googleapis#81](https://www..com/googleapis/java-spanner-jdbc/issues/81)) ([a5e031d](https://www..com/googleapis/java-spanner-jdbc/commit/a5e031d3183f8fe88a621500f235ca2b0242f50b))
* include Spanner gRPC test dependencies ([googleapis#63](https://www..com/googleapis/java-spanner-jdbc/issues/63)) ([a34bfc0](https://www..com/googleapis/java-spanner-jdbc/commit/a34bfc0ff1c2ddeef077dbfae4c56bdd53febcb2))


### Dependencies

* update core dependencies ([1ae098e](https://www..com/googleapis/java-spanner-jdbc/commit/1ae098e924c2a488cfddd0a3aee9511274b7a515))
* update core dependencies ([googleapis#40](https://www..com/googleapis/java-spanner-jdbc/issues/40)) ([18c3a1b](https://www..com/googleapis/java-spanner-jdbc/commit/18c3a1b069cb507a91d0320e64a8bf8ae8efe394))
* update core dependencies ([googleapis#73](https://www..com/googleapis/java-spanner-jdbc/issues/73)) ([cfa1539](https://www..com/googleapis/java-spanner-jdbc/commit/cfa153997599c36f1243e87f1ea0760694657dfe))
* update core dependencies to v1.27.1 ([googleapis#61](https://www..com/googleapis/java-spanner-jdbc/issues/61)) ([181991b](https://www..com/googleapis/java-spanner-jdbc/commit/181991bda1f66de707d27dad9658b9177626595a))
* update core dependencies to v1.27.2 ([googleapis#71](https://www..com/googleapis/java-spanner-jdbc/issues/71)) ([12425fc](https://www..com/googleapis/java-spanner-jdbc/commit/12425fcb4382449e4a7a0edad4c812b7ce15aa71))
* update core dependencies to v1.54.0 ([googleapis#72](https://www..com/googleapis/java-spanner-jdbc/issues/72)) ([5676021](https://www..com/googleapis/java-spanner-jdbc/commit/567602177e05fa198eaa011fbca05cfe4b72fb13))
* update core dependencies to v1.92.5 ([googleapis#53](https://www..com/googleapis/java-spanner-jdbc/issues/53)) ([604ee2b](https://www..com/googleapis/java-spanner-jdbc/commit/604ee2b75204ad52eaf724c3fb71e8c13540af7c))
* update core transport dependencies to v1.34.1 ([googleapis#43](https://www..com/googleapis/java-spanner-jdbc/issues/43)) ([2b6f04d](https://www..com/googleapis/java-spanner-jdbc/commit/2b6f04da3aeebac778fb664c4564fb8b58bf3be4))
* update core transport dependencies to v1.34.2 ([googleapis#62](https://www..com/googleapis/java-spanner-jdbc/issues/62)) ([8739015](https://www..com/googleapis/java-spanner-jdbc/commit/8739015f62289adb92fd55b19a5bff8762da20a9))
* update dependency com.google.api-client:google-api-client-bom to v1.30.8 ([googleapis#46](https://www..com/googleapis/java-spanner-jdbc/issues/46)) ([ef891b0](https://www..com/googleapis/java-spanner-jdbc/commit/ef891b000045d1f39f91b6a0ed3abaab19c5f05e))
* update dependency com.google.api-client:google-api-client-bom to v1.30.9 ([googleapis#74](https://www..com/googleapis/java-spanner-jdbc/issues/74)) ([3b62299](https://www..com/googleapis/java-spanner-jdbc/commit/3b622999b9f9645a6086e5efd3206f4d7b0806bc))
* update dependency com.google.truth:truth to v1.0.1 ([googleapis#32](https://www..com/googleapis/java-spanner-jdbc/issues/32)) ([5205863](https://www..com/googleapis/java-spanner-jdbc/commit/52058636e10951e883523204f0f161db8a972d62))
* update protobuf.version to v3.11.3 ([googleapis#48](https://www..com/googleapis/java-spanner-jdbc/issues/48)) ([0779fcb](https://www..com/googleapis/java-spanner-jdbc/commit/0779fcb0bfe935c3c302fa8442f733c7e3629761))
* update protobuf.version to v3.11.4 ([googleapis#64](https://www..com/googleapis/java-spanner-jdbc/issues/64)) ([f485cff](https://www..com/googleapis/java-spanner-jdbc/commit/f485cfffa0de27ce35f5d16c689c31c6ea22138e))
* update spanner.version to v1.51.0 ([googleapis#75](https://www..com/googleapis/java-spanner-jdbc/issues/75)) ([4fff168](https://www..com/googleapis/java-spanner-jdbc/commit/4fff168eae61fb55933cf3afd67f24ca65dfde54))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@skuruppu skuruppu skuruppu approved these changes

@hengfengli hengfengli Awaiting requested review from hengfengli

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.