Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
| databaseClient | ||
| .readWriteTransaction(Options.tag("app=concert,env=dev")) | ||
| .run( | ||
| new TransactionCallable<Void>() { |
There was a problem hiding this comment.
nit: could you use Java 8 lambda notation instead of an anonymous class?
.run(transaction -> {
...
})
| // Execute query multiple times to give a better chance of being part of the TopN tables. | ||
| for (int i = 0; i < 50; i++) { | ||
| final String out = runSample(() -> TransactionWithTagSample.setRequestTag(client)); | ||
| assertThat(out).contains("1 1 title 1"); |
There was a problem hiding this comment.
How long does this take to run? Could we break as soon as we reach a condition?
| if (queryStatsFound) { | ||
| break; | ||
| } | ||
| Thread.sleep(5000); |
There was a problem hiding this comment.
Could we reduce the sleep time here?
Closing in favour of #1496 |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Supersedes #1042
Adds a sample for assigning and querying tags.
Follow-up to #576
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️