Fixes #344

Codecov Report

Merging #352 into master will increase coverage by 0.40%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
+ Coverage     62.73%   63.13%   +0.40%     
- Complexity      554      601      +47     
============================================
  Files            31       32       +1     
  Lines          5023     5078      +55     
  Branches        480      481       +1     
============================================
+ Hits           3151     3206      +55     
- Misses         1707     1708       +1     
+ Partials        165      164       -1     

Impacted Files	Coverage Δ	Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java	80.90% <ø> (ø)	0.00 <0.00> (ø)
...main/java/com/google/cloud/storage/BucketInfo.java	81.34% <85.71%> (+0.29%)	83.00 <2.00> (-1.00)	⬆️
...src/main/java/com/google/cloud/storage/Bucket.java	81.36% <100.00%> (+0.13%)	34.00 <0.00> (ø)
...ogle/cloud/storage/testing/StorageRpcTestBase.java	97.95% <0.00%> (ø)	48.00% <0.00%> (?%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b04dd...0a574ba. Read the comment docs.

List<LifecycleRule> deleteLifecycleRules(String bucket, LifecycleRule... rulesToDelete);

Neither Storage nor Bucket defines methods to deal with LifecycleRules. Adding a method to them to delete that rules doesn't look logical. Would it make sense to implement this functionality in the BucketInfoclass next to List<? extends BucketInfo.LifecycleRule> getLifecycleRules() method?

cc: @frankyn

+1 to @dmitry-fa, it would be better to define this in the BlobInfo builder because that's how metadata is mutated.

@frankyn @dmitry-fa PTAL

@frankyn PTAL

The new implementation is much better than the previous one. Could you fix a few nits, please.

I think you're super close, but I may have been too short on my surface expectations. Provided an example of what I would expect.

[frankyn]

I'm expecting the following surface:

String bucketName = "my-unique-bucket";
Bucket bucket = storage.get(bucketName);

updatedBucketMetdata = bucket.toBuilder().deleteLifecycleRules().build().update();
if (updatedBucketMetadata.getLifecycleRules().size() == 0) {
    // the lifecycle rules were deleted
}

[athakor]

done

@frankyn @dmitry-fa implemented in the same manner as other methods updating Bucket's properties. PTAL when you get chance

Overall looks good to me. A few nits to address just left.

@dmitry-fa all the comments have been addressed PTAL

Looks good to me know, thanks for addressing my comments.