Conversation

francois-baptiste

Fixes #109 🦕

@googlebot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your account.

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added the cla: noThis human has *not* signed the Contributor License Agreement.label May 18, 2020
@francois-baptiste

@googlebot I signed it!

@googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: yesThis human has signed the Contributor License Agreement.and removed cla: noThis human has *not* signed the Contributor License Agreement.labels May 18, 2020
@francois-baptistefrancois-baptiste force-pushed the -1 branch 2 times, most recently from cf848fd to 9e6f770 Compare May 18, 2020 09:31
@IlyaFaerIlyaFaer added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label May 18, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main concern with this change, while nice on its own, is that it can break existing user code as the failed tests show. I'm not sure if evaluability of the representation is really worth it.

@shollyman Your thoughts?

@francois-baptiste

Thank you for your help @plamut.
I reworked the pull request from scratch. The properties from TimePartitioningobject are now converted from the REST API to the python API in the repr method.

@francois-baptistefrancois-baptiste changed the title Makes TimePartitioning printable representation evaluable fix: makes TimePartitioning printable representation evaluable May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, thanks for the refactoring! Changing only the representation is much less of a concern than changing a method signature.

One of the tests broke, though, and should be fixed, the rest are some very minor comments.
(not sure why the CI status is not reported, though...)

@googlebot

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: noThis human has *not* signed the Contributor License Agreement.and removed cla: yesThis human has signed the Contributor License Agreement.labels May 25, 2020
@googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: yesThis human has signed the Contributor License Agreement.and removed cla: noThis human has *not* signed the Contributor License Agreement.labels May 25, 2020
@plamutplamut added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label May 26, 2020
@tseaver

@shollyman Any follow up on the open internal questions you raised?

@tseavertseaver added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Jul 30, 2020
@tseavertseaver added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jul 30, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jul 30, 2020
@busunkim96busunkim96 reopened this Jul 31, 2020
@tseavertseaver added the kokoro:runAdd this label to force Kokoro to re-run the tests.label Aug 6, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Aug 6, 2020
@plamut

@shollyman Friendly ping. :) Any updates on those internal questions to date?

@plamutplamut requested a review from cguardia August 28, 2020 10:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready, but seems like nothing can be done until the internal issue is resolved.

@shollyman

Documentation for behavior is getting updated. Lack of value will be treated as DAY interval.

@tswasttswast requested a review from a team October 6, 2020 22:03
@tswasttswast added kokoro:runAdd this label to force Kokoro to re-run the tests.and removed do not mergeIndicates a pull request not ready for merge, due to either quality or timing.labels Oct 6, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 6, 2020
@tswasttswast added kokoro:runAdd this label to force Kokoro to re-run the tests.automergeMerge the pull request once unit tests and other checks pass.labels Oct 13, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 13, 2020
@gcf-merge-on-greengcf-merge-on-green bot merged commit 20f473b into googleapis:master Oct 13, 2020
@gcf-merge-on-greengcf-merge-on-green bot removed the automergeMerge the pull request once unit tests and other checks pass.label Oct 13, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 19, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://www..com/googleapis/python-bigquery/compare/v2.1.0...v2.2.0) (2020-10-19)


### Features

* add method api_repr for table list item ([#299](https://www..com/googleapis/python-bigquery/issues/299)) ([07c70f0](https://www..com/googleapis/python-bigquery/commit/07c70f0292f9212f0c968cd5c9206e8b0409c0da))
* add support for listing arima, automl, boosted tree, DNN, and matrix factorization models ([#328](https://www..com/googleapis/python-bigquery/issues/328)) ([502a092](https://www..com/googleapis/python-bigquery/commit/502a0926018abf058cb84bd18043c25eba15a2cc))
* add timeout paramter to load_table_from_file and it dependent methods ([#327](https://www..com/googleapis/python-bigquery/issues/327)) ([b0dd892](https://www..com/googleapis/python-bigquery/commit/b0dd892176e31ac25fddd15554b5bfa054299d4d))
* add to_api_repr method to Model ([#326](https://www..com/googleapis/python-bigquery/issues/326)) ([fb401bd](https://www..com/googleapis/python-bigquery/commit/fb401bd94477323bba68cf252dd88166495daf54))
* allow client options to be set in magics context ([#322](https://www..com/googleapis/python-bigquery/issues/322)) ([5178b55](https://www..com/googleapis/python-bigquery/commit/5178b55682f5e264bfc082cde26acb1fdc953a18))


### Bug Fixes

* make TimePartitioning repr evaluable ([#110](https://www..com/googleapis/python-bigquery/issues/110)) ([20f473b](https://www..com/googleapis/python-bigquery/commit/20f473bfff5ae98377f5d9cdf18bfe5554d86ff4)), closes [#109](https://www..com/googleapis/python-bigquery/issues/109)
* use version.py instead of pkg_resources.get_distribution ([#307](https://www..com/googleapis/python-bigquery/issues/307)) ([b8f502b](https://www..com/googleapis/python-bigquery/commit/b8f502b14f21d1815697e4d57cf1225dfb4a7c5e))


### Performance Improvements

* add size parameter for load table from dataframe and json methods ([#280](https://www..com/googleapis/python-bigquery/issues/280)) ([3be78b7](https://www..com/googleapis/python-bigquery/commit/3be78b737add7111e24e912cd02fc6df75a07de6))


### Documentation

* update clustering field docstrings ([#286](https://www..com/googleapis/python-bigquery/issues/286)) ([5ea1ece](https://www..com/googleapis/python-bigquery/commit/5ea1ece2d911cdd1f3d9549ee01559ce8ed8269a)), closes [#285](https://www..com/googleapis/python-bigquery/issues/285)
* update snippets samples to support version 2.0 ([#309](https://www..com/googleapis/python-bigquery/issues/309)) ([61634be](https://www..com/googleapis/python-bigquery/commit/61634be9bf9e3df7589fc1bfdbda87288859bb13))


### Dependencies

* add protobuf dependency ([#306](https://www..com/googleapis/python-bigquery/issues/306)) ([cebb5e0](https://www..com/googleapis/python-bigquery/commit/cebb5e0e911e8c9059bc8c9e7fce4440e518bff3)), closes [#305](https://www..com/googleapis/python-bigquery/issues/305)
* require pyarrow for pandas support ([#314](https://www..com/googleapis/python-bigquery/issues/314)) ([801e4c0](https://www..com/googleapis/python-bigquery/commit/801e4c0574b7e421aa3a28cafec6fd6bcce940dd)), closes [#265](https://www..com/googleapis/python-bigquery/issues/265)
---


This PR was generated with [Release Please](https://.com/googleapis/release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

TimePartitioning printable representation is not evaluable