Conversation

ryanyuan

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #290 🦕

@ryanyuanryanyuan requested a review from a team October 2, 2020 12:05
@ryanyuanryanyuan requested a review from a team as a code owner October 2, 2020 12:05
@ryanyuanryanyuan requested a review from engelke October 2, 2020 12:06
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Oct 2, 2020
tswast
tswast reviewed Oct 2, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you also add a test file to the samples directory?

@ryanyuan

Thanks for the contribution! Could you also add a test file to the samples directory?

Done.

PTAL. Cheers! @tswast

@tswasttswast added the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 5, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 5, 2020
@tswasttswast added the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 6, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 6, 2020
@tswasttswast added the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 6, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Oct 6, 2020
engelke
engelke approved these changes Oct 6, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswasttswast merged commit d1eb8b3 into googleapis:master Oct 6, 2020
@tswast

@ryanyuan Thanks so much for the contribution. Just sent internal change 335690842 out for review to get this added to the cloud.google.com docs.

@ryanyuan

@ryanyuan Thanks so much for the contribution. Just sent internal change 335690842 out for review to get this added to the cloud.google.com docs.

Awesome! Thank you @tswast

gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 8, 2020
@release-please
chore: release 2.1.0 (#301)
1a4dc12
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.1.0](https://www..com/googleapis/python-bigquery/compare/v2.0.0...v2.1.0) (2020-10-08)


### Features

* add constants for MONTH and YEAR time partitioning types ([#283](https://www..com/googleapis/python-bigquery/issues/283)) ([9090e1c](https://www..com/googleapis/python-bigquery/commit/9090e1ccd8825a97835325b4829f6e7ecfd9ea88))


### Bug Fixes

* remove unnecessary dependency on libcst ([#308](https://www..com/googleapis/python-bigquery/issues/308)) ([c055930](https://www..com/googleapis/python-bigquery/commit/c05593094c1405f752b2c51b15202a6dbb5cb83f))


### Performance Improvements

* remove redundant array deepcopy ([#26](https://www..com/googleapis/python-bigquery/issues/26)) ([b54f867](https://www..com/googleapis/python-bigquery/commit/b54f86769c982ce5c8fcbf3889f82450428bb40c))


### Documentation

* **samples:** add create_table_clustered code snippet ([#291](https://www..com/googleapis/python-bigquery/issues/291)) ([d1eb8b3](https://www..com/googleapis/python-bigquery/commit/d1eb8b3dcc789916c5d3ba8464f62b1f8bef35ff))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@engelke engelke engelke approved these changes

@tswast tswast tswast approved these changes

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.

Add create_table_clustered sample code