Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits April 27, 2021 07:19
Because we don't want to accidentally create a giant bytes.
tswast reviewed Apr 27, 2021
google/cloud/bigquery/dbapi/types.py Outdated
| if isinstance(data, int): | ||
| # This is not the conversion we're looking for, because it | ||
| # will simply create a bytes object of the given size. | ||
| raise TypeError("cannot convert 'decimal.Decimal' object to binary") |
There was a problem hiding this comment.
isinstance is checking for int, but the error says decimal.Decimal
tests/unit/test_dbapi_types.py Outdated
| @@ -13,6 +13,7 @@ | |||
| # limitations under the License. | |||
| import datetime | |||
| import pytest | |||
There was a problem hiding this comment.
Nit: We usually put pytest in the second grouping of imports rather than with the built-ins. We do try to follow PEP-8 advice.
Imports should be grouped in the following order:
- Standard library imports.
- Related third party imports.
- Local application/library specific imports.
You should put a blank line between each group of imports.
tests/unit/test_dbapi_types.py Outdated
| self.assertEqual(types.Binary(C()), b"Google") | ||
| for bad in 42, 42.0, None: |
There was a problem hiding this comment.
I'd expect the tests for "bad inputs" to be in a separate test function.
Ideally both of these (good inputs, bad inputs) would be parameterized in pytest-style tests. I think we can actually mix those in to the same file, so we can do that without refactoring everything, especially since these tests don't require any of the setup from the unit test class.
tswast approved these changes Apr 27, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.15.0](https://www..com/googleapis/python-bigquery/compare/v2.14.0...v2.15.0) (2021-04-29) ### Features * Extended DB API parameter syntax to optionally provide parameter types ([#626](https://www..com/googleapis/python-bigquery/issues/626)) ([8bcf397](https://www..com/googleapis/python-bigquery/commit/8bcf397fbe2527e06317741875a059b109cfcd9c)) ### Bug Fixes * add DECIMAL and BIGDECIMAL as aliases for NUMERIC and BIGNUMERIC ([#638](https://www..com/googleapis/python-bigquery/issues/638)) ([aa59023](https://www..com/googleapis/python-bigquery/commit/aa59023317b1c63720fb717b3544f755652da58d)) * The DB API Binary function accepts bytes data ([#630](https://www..com/googleapis/python-bigquery/issues/630)) ([4396e70](https://www..com/googleapis/python-bigquery/commit/4396e70771af6889d3242c37c5ff2e80241023a2)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please). See [documentation](https://.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #628 🦕