Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using aioble/l2cap to send data from micropython to a cental like a phone, if the ble disconnects in the middle of a send process it can currently fail with the exception:
This is because the send function is operating in a loop sending the data in chunks.
At the top of the function
self._assert_connected()
is already called which will raise aL2CAPDisconnectedError
if the connection has already been dropped (as detected byself._cid is None
however the chunk send loop can run for some time, a disconnect in the middle of this results inself._cid = None
being passed toble.l2cap_send()
resulting in the exception above.This PR simply adds the correct connection check immediately before each loop of
l2cap_send()
.