Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add single-file module for the Microchip MCP9808 precision temperature sensor. The module provides a class for reading the temperature and for configuring the sensor. It has type/value checking for some of the critical parts of the configuration as well as a debug mode for easier testing during development. It includes a test file designe to run directly on a board with a sensor connected to test both the module and the sensor. Both module and tests file are thoroughly documented in the code directly. For more information read README.md on MarcoMiano/mip-mcp9808 Signed-off-by: MarcoMiano <[email protected]>
Signed-off-by: MarcoMiano <[email protected]>
Signed-off-by: MarcoMiano <[email protected]>
ruff suggest to use .isinstance() to check class type but bool doen't have .isinstance() method. ruff suggest to use only float in some places but i don't like it the code should be more flexible. Signed-off-by: MarcoMiano <[email protected]>
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add single-file module for the Microchip MCP9808 precision temperature sensor. The module provides a class for reading the emperature and for configuring the sensor. It has type/value checking for some of the critical parts of the configuration as well as a debug mode for easier testing during development.
It includes a test file designed to run directly on a board with a sensor connected to test both the module and the sensor.
Both module and tests file are thoroughly documented in the code directly. For more information read README.md on https://.com/MarcoMiano/mip-mcp9808
edit:
It is my first pr here so bear with me with all this pre-commit stuff... (had black fighting with ruff in vscode for a moment)
I still don't get what the check doesn't like in my commits... I don't want to use my email to sign-off stuff.