Open
Changes from all commits
Show all changes
12 commitsSelect commit Hold shift + click to select a range
9abbd6e
adds override for sidecar containers
ab-andrescaf8ca53
adds blanket variable to add containers into daemonset or deployment
ab-andresc830720f
adds blanket variable to add containers into daemonset or deployment
ab-andresc22c1c38
moves extracontainers to correct location
ab-andrescf10c285
adds schema and readme updates
ab-andresc2edc176
better image
ab-andresc9cd71f9
added securitycontext overrides
ab-andrescb4a587f
added securitycontext overrides
ab-andresca9e3437
added securitycontext overrides
ab-andresc5dd677b
added securitycontext overrides
ab-andresc31eaea7
Merge branch 'main' into -1
ab-andresc9dfbd00
overrides security context
ab-andrescFile filter
Filter by extension
Conversations
Failed to load comments.
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Failed to load files.
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -397,6 +397,12 @@ type DeploymentSpec struct { | ||||||||
// | ||||||||
// +optional | ||||||||
Container ContainerSpec `json:"container"` | ||||||||
// ExtraContainers defines additional containers to be added to the NGINX Pod. | ||||||||
// Uses upstream corev1.Container to allow arbitrary sidecars. | ||||||||
// | ||||||||
// +optional | ||||||||
ExtraContainers []corev1.Container `json:"extraContainers,omitempty"` | ||||||||
} | ||||||||
// DaemonSet is the configuration for the NGINX DaemonSet. | ||||||||
@@ -410,6 +416,11 @@ type DaemonSetSpec struct { | ||||||||
// | ||||||||
// +optional | ||||||||
Container ContainerSpec `json:"container"` | ||||||||
// ExtraContainers defines additional containers to be added to the NGINX Pod. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggested change
| ||||||||
// Uses upstream corev1.Container to allow arbitrary sidecars. | ||||||||
// | ||||||||
// +optional | ||||||||
ExtraContainers []corev1.Container `json:"extraContainers,omitempty"` | ||||||||
} | ||||||||
// PodSpec defines Pod-specific fields. | ||||||||
@@ -453,6 +464,8 @@ type PodSpec struct { | ||||||||
// | ||||||||
// +optional | ||||||||
TopologySpreadConstraints []corev1.TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty"` | ||||||||
SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"` | ||||||||
} | ||||||||
// ContainerSpec defines container fields for the NGINX container. | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great if you could specify one example of the
sidecars
users can use.