• Implement an EnumType for MySQL/MariaDB doctrine/dbal#6536 (since dbal 4.2)
• Add SmallFloat type doctrine/dbal#6471 (since dbal 4.1)
• Resolves Doctrine DBAL 4.2 ships an Types::ENUM which should be preferred over implementing custom types for ENUM fields. #619

[janedbal]

At first, I tried adding new doctrine versions to composer.json, but it would require bigger effort to adjust this repo to support those everywhere, so I just referenced those not-yet-existing classes.

• tests describing what this actually fixes would be nice

[ondrejmirtes]

No inheritance please

[janedbal]

Are you sure? I believe SmallFloatType IS FloatType in terms of type descriptor.

[VincentLanglet]

Am I wrong or without this type the data is considered as mixed ?

Now with this, it will report error foo be 'A'|'B' but is string on level 8 because the values option is not considered in the following code

#[ORM\Column(name: 'foo', type: Types::ENUM, options: ['values' => ['A', 'B'])]

[janedbal]

Am I wrong or without this type the data is considered as mixed ?

You are correct.

tests describing what this actually fixes would be nice

It is pretty painful to test new doctrine here (due to all the compatibility hacks). But added.

The enum type will introduce new false-positive.

Before

/**
   * @Column(type="enum", options={"values"={"a", "b", "c"}})
   * @var 'a'|'b'|'c'
   *
   public $enum;

Was reported level 9 (mixed is not 'a'|'b'|'c')
and now will be reported on a lower level (string is not 'a'|'b'|'c')

Would it be possible to read the options ?

Would it be possible to read the options ?

Yes, implemented.

Would it be possible to read the options ?

Yes, implemented.

Great.

Could add a test for the EntityColumnRule too

class EntityColumnRuleTest extends RuleTestCase

(I assume we just need to add an enum field in the BrokenEntity https://.com/phpstan/phpstan-doctrine/blob/a1a9efb64708580a9d8b0d150340f7777d2b8aa0/tests/Rules/Doctrine/ORM/data/MyBrokenEntity.php)

I assume that

/**
   * @Column(type="enum", options={"values"={"a", "b", "c"}})
   * @var 'a'|'b'|'c'
   *
   public $enum;

shouldn't be reported but

/**
   * @Column(type="enum", options={"values"={"a", "b", "c"}})
   * @var string
   *
   public $enumWithUnprecisedPHPDoc;

should be reported