Conversation

sdwilsh

Summary:
Add last_token_pos in the forward options.

Purpose:

  • the last norm and output of lm-head can be performed with the last valid token at prefill.
  • If the input sequence length is fixed when an accelerator doesn't support the dynamic shapes, selecting the last token from the input is not always guaranteed as valid.
  • Thus, it needs an additional pointer to select the last valid token only to perform the last norm and output.

Differential Revision: D76440105

Summary:
Add last_token_pos in the forward options.

Purpose:
* the last norm and output of lm-head can be performed with the last valid token at prefill.
* If the input sequence length is fixed when an accelerator doesn't support the dynamic shapes, selecting the last token from the input is not always guaranteed as valid.
* Thus, it needs an additional pointer to select the last valid token only to perform the last norm and output.

Differential Revision: D76440105
@pytorch-botPyTorch Bot

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11793

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit b526c43 with merge base 3c05b6c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook--bot added the CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.label Jun 18, 2025
@facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D76440105

@github-actionsGitHub Actions

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorct, for example
@pytorct label "release notes: none"

For more information, see
https://.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exported
None yet

Successfully merging this pull request may close these issues.