Conversation

larryliu0820

Currently compiling text_llm_runner.cpp requires a dependency to libsentencepiece.a and Xcode requires that library to be installed

at a directory in ${TEMP_DIR}/cmake/lib

For example on my laptop:

/Users/larryliu/Library/Developer/Xcode/DerivedData/Benchmark-dvseychddztwtucwgxpumwmyedfh/Build/Intermediates.noindex/Benchmark.build/Release-iphoneos/Tests.build/cmake/lib

Before we don't install sentencepiece, this PR changes it to install it.

To see the diff clearly: use this link https://www.internalfb.com/intern/diffing/?paste_number=1846901681

Screenshot 2025-06-20 at 2 28 19 PM

…entencepiece

Now compiling `text_llm_runner.cpp` requires a dependency to `libsentencepiece.a` and Xcode requires that library to be installed

at a directory in ${TEMP_DIR}/cmake/lib

For example on my laptop:

```
/Users/larryliu/Library/Developer/Xcode/DerivedData/Benchmark-dvseychddztwtucwgxpumwmyedfh/Build/Intermediates.noindex/Benchmark.build/Release-iphoneos/Tests.build/cmake/lib
```

Currently we don't install sentencepiece, this PR changes it to install it.
@pytorch-botPyTorch Bot

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11834

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit bbbd91c with merge base 496cb05 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook--bot added the CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.label Jun 20, 2025
@larryliu0820larryliu0820 added the release notes: noneDo not include this in the release noteslabel Jun 20, 2025
@shoumikhin

Is this also applicable to the LLaMA demo app?

@larryliu0820

Is this also applicable to the LLaMA demo app?

Yep you are right, let me add that

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple / build-benchmark-app passed. Accepted to unblock continuous benchmarking

@larryliu0820larryliu0820 merged commit 121714a into main Jun 23, 2025
210 of 215 checks passed
@larryliu0820larryliu0820 deleted the fix_benchmark branch June 23, 2025 07:54
Sign up for free to join this conversation on . Already have an account? Sign in to comment
ciflow/trunk CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes
None yet

Successfully merging this pull request may close these issues.