Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3cdebdc to 9da074e Compare joecummings commented Dec 27, 2022
| encoder_output = model_kwargs["encoder_outputs"][encoder_output_key] | ||
| def update_func(emissions, N, T, prev_step_token_idxs, prev_step_model_states, timestep): | ||
| # `emissions` and `N` are unused in this current implementation |
There was a problem hiding this comment.
Could change this around to take in emissions, but AFAIK there is no easy way to get the actual tensor from the data_ptr.
joecummings commented Dec 27, 2022
| return final_tokens_as_tensors | ||
| if num_python_workers > 1: |
There was a problem hiding this comment.
PyTorch has a MP module (essentially a clone of Python's MP); however, this relies on pickle, which means all of these functions would have to be at a global level. Very open to suggestions here.
e2b999c to 9f2d2d6 Compare 9f2d2d6 to 64597a5 Compare a78dd94 to 3fd765e Compare Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.