Conversation

jeanschmidt

testing new runners

NivekT and others added 30 commits May 16, 2022 17:12
…be pickled (#1726)

For Datasets, refactor local functions to be global so that they can be pickled
* Add support for CoLA dataset + unit tests
* Better test with differentiated rand_string
* Remove lambda functions
* Add dataset documentation
* Add shuffle and sharding
* Add support for MRPC dataset
* Add unit tests
* Remove lambda functions
* Add dataset documentation
* Add shuffle and sharding
* Add QQP dataset + unit test
* Adjust output + add different strings for tests
* Remove lambda functions + correct docstring
* Add dataset documentation
* Add shuffle and sharding
* Add support for MNLI + add tests
* Adjust dataset size docstring
* Remove lambda functions
* Add dataset documentation
* Add shuffle and sharding
* Add support for STS-B dataset _ unit test
* Modify tests + docstring
* Add dataset documentation
* Add shuffle and sharding
* Adding test to check if datasets are pickleable. Fixing IMDB local fn

* Removed local functions from dataaset implementations

* Updated parameterization inputs

* Fixing stsb
1. Fix `collapsedSections is not defined` error.
PyTorch Sphinx theme seems to expect that `collapsedSections`
variable to be defined before its theme.js is executed.

2. Overwrite the link to  project to torchtext
So that documentation link to torchtext's repository instead of
PyTorch core.
* Pin setuptools to 58.0.4 on Windows

* Fix lint issues
* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.

* Removed ticks (``) from the url under is_module_available

Ticks can result in re-direction to 'https://.com/pytorch/data%60' instead of 'https://.com/pytorch/data', which is not a valid resource.
Tested in Colab.
* Support QNLI dataset + added unit tests
* Add dataset documentation
* Add shuffle and sharding
* Change local to global functions in test + lint
* Add support for RTE dataset + unitest
* Add dataset documentation
* Add shuffle and sharding
* Move local to global functions + use load_from_zip
* Add support for WNLI dataset + unit tests
* Add dataset documentation
* Add shuffle and sharding
* Move local to global functions + use load_from_zip
* Added post install script for pywin32

* Update command to python

* fix incorrect file extension

* trying pinned version of pywin

* Readding post script install

* Moved post install to install.sh
…1742)

* Add contributing guidelines for third party libraries and custom C++ operators

* Fix formatting

* Fixing PR comments

* Resolve PR comment
osalpekar and others added 28 commits May 16, 2023 10:59
* [Nova] Deprecate Remaining CircleCI unittest jobs

* Remove more unused job deps
* Remove circleci doc build job

* Rebase

* Remove unittests

* Fix ufmt

* flake8

* Format prettier
* [NovaX] Lint Job on GHA

* fix lint errors

* pre-commit run all files

* conda env to path

* install older node

* no need to remove prev libs

* no source bashrc

* default sys node

* specific node version

* fixing lint errors raised by whitespace detector

* Remove CCI job
* Remove Unused Docker build

* Deleting CircleCI directory entirely

* Revert "Deleting CircleCI directory entirely"

This reverts commit f47af2f.

* Remove CCI configs

* Remove unused scripts
* Add TorchFix linter

* Move comments to separate lines

* Change assert_allclose to assert_close
* Update to TorchFix 0.0.2

* Update .flake8
* Move tensor to CPU before converting to string for unpickle

Summary:
The loaded tensor could be on CUDA, whose data cannot to converted to a std::string.

This change moves tensor to CPU first. Then data can be converted.

Reviewed By: mortzur

Differential Revision: D48057806

fbshipit-source-id: ad495bb2e84f9aab5120d5462d4d1c381719d014

* Del `(object)` from 10 inc pytorch/tensorboardX/tensorboardX/record_writer.py

Summary: Python3 makes the use of `(object)` in class inheritance unnecessary. Let's modernize our code by eliminating this.

Reviewed By: meyering

Differential Revision: D48958009

fbshipit-source-id: aa42e55a827d83aadf1b10b2de79317c3761ab7a

---------

Co-authored-by: Henry Hu <[email protected]>
Co-authored-by: Richard Barnes <[email protected]>
* Fix torchdata install command - use index-url

* fix
This notebook is an example of a (working) "Hacky" solution for wrapping the full 'generate' functionality inside a "forward" function.
The perpose of this is to start a discussion and be a suggention on how to make the this functionality TorchScriptable.

To do so, I:

1. T5TorchGenerative: inherited from T5Model:
- extracted the decoding code from t5.forward() function to a standalone 'decode' function that returns a specific type.
- added the GenerationUtils's 'generate' functionality as a class method (similar to HuggingFace).
2. Added TorchScriptableT5, a module that implements the full generative logic in the forward method.
3. Helper classes that build a jit (TorchScript) model from a predefined T5 Bundle

Co-authored-by: Roei Bahumi <[email protected]>
* [oidc] switch text wheels to oidc

* Grant id-token write permission

* Update build-wheels-m1.yml

* Update build-wheels-macos.yml

* Update build-wheels-windows.yml

---------

Co-authored-by: Huy Do <[email protected]>
* Update README.rst

Make it clear that this repository is not actively maintained by PyTorch anymore.

* Update README.rst
* Remove stuff

* stuff

* lint
@pytorch-botPyTorch Bot

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2267

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 4 Unrelated Failures

As of commit a817dd6 with merge base 09e2690 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.